Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
In my stupidity, I saw this output:
One time login url: <http://127.0.0.1:8890/user/reset/1/1525471291/YDs8yfQOMeXtO9i6_AVVFBbkPmLImvVb-5Wctg4bb5Q/login>
Press Ctrl-C to quit.
... and assumed it was instructing me to click the link, then hit Ctrl-C to end the quick start process.
I also was in #contribute and asked "hey how do I kill the server when I'm done so it's not eating up resources?"
So, basically:
- I hit Ctrl+C thinking it was the last part of the script's process.
- I killed my server without realizing it.
- And nowhere along the way did I realize Ctrl+C was how I was meant to kill the server.
Something more along the lines of The server is running. Press Ctrl-C to terminate it.
would have prevented this (for me, at least).
Comment | File | Size | Author |
---|---|---|---|
#7 | 2969718-2.patch | 847 bytes | runeasgar |
#3 | 2969718-1.patch | 862 bytes | runeasgar |
Comments
Comment #2
runeasgar CreditAttribution: runeasgar as a volunteer commentedComment #3
runeasgar CreditAttribution: runeasgar as a volunteer commentedI made a patch :D figures the first issue that's simple enough for me to patch myself, is an issue I filed myself.
I also tested it. The new text is:
The Drupal development server is running. Press Ctrl-C to stop it.
I tried to keep it close to other terminology that is already used in the output.
Comment #4
geerlingguy CreditAttribution: geerlingguy at Midwestern Mac, LLC commentedAssuming tests pass. Better UX for those who might not be used to running servers in the foreground via the CLI.
Comment #5
dawehnerThank you for the improvement!
Comment #6
alexpottThis is duplicating one of lines above which the paste from the issue summary doesn't include, ie.
Drupal development server started:
I think that changing this to
Press Ctrl-C to quit the Drupal development server.
would be better. Less words and less repetitive.Comment #7
runeasgar CreditAttribution: runeasgar as a volunteer commentedI'm personally partial to the term "stop" when it comes to shutting down a server process, but here's a patch with your exact wording :p
Comment #8
borisson_#6 is resolved with the patch in #7. I agree with @alexpott that this is clear enough.
Comment #9
alexpottI agree that services are stopped. But this is not a service - it is something running in the foreground and those are quit. The original was also an exact copy what you see when using the in-built PHP webserver interactively so I think it is fair to continue to copy their language.
Comment #10
alexpottCommitted 0652f65 and pushed to 8.6.x. Thanks!
Comment #12
runeasgar CreditAttribution: runeasgar as a volunteer commentedMakes sense, thanks for clarifying.