Problem/Motivation

We should remove usages of setPublished() method with a parameter and only use the methods setPublished() and setUnpublished().

Proposed resolution

Replace all the usages of setPublished() method with a parameter with setPublished() or setUnpublished() methods where corresponding.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#9 interdiff-2969549-8-9.txt541 bytesmartin107
#9 2969549-9.patch20.74 KBmartin107
#8 2969549-8.patch20.39 KBmarcel66
#6 interdiff-4.txt1.45 KBmarcel66
#6 2969549-4.patch22 KBmarcel66
#4 interdiff-3.txt948 bytesmarcel66
#4 2969549-3.patch21.84 KBmarcel66
#2 2969549-2.patch22.76 KBmarcel66
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rteijeiro created an issue. See original summary.

marcel66’s picture

marcel66 CreditAttribution: marcel66 as a volunteer commented
Status: Active » Needs review
FileSize
2969549-2.patch22.76 KB

Patch written at DC Transylvania 2018 with amateescu.

Status: Needs review » Needs work

The last submitted patch, 2: 2969549-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

marcel66’s picture

marcel66 CreditAttribution: marcel66 as a volunteer commented
Status: Needs work » Needs review
FileSize
2969549-3.patch21.84 KB
interdiff-3.txt948 bytes

Lets see if this fixes all the fails.

Status: Needs review » Needs work

The last submitted patch, 4: 2969549-3.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

marcel66’s picture

marcel66 CreditAttribution: marcel66 as a volunteer commented
Status: Needs work » Needs review
FileSize
2969549-4.patch22 KB
interdiff-4.txt1.45 KB

I think this will work. Sorry ... was my first patch.

martin107’s picture

martin107 CreditAttribution: martin107 as a volunteer commented
Status: Needs review » Needs work

Hi @marcel66,

No problem, .... congratulations on the first patch ...

the file interdiff-4.txt has been caught up in the new patch

marcel66’s picture

marcel66 CreditAttribution: marcel66 as a volunteer commented
Status: Needs work » Needs review
FileSize
2969549-8.patch20.39 KB

Thank you for observation and patient. Attached new patch without interdiff

martin107’s picture

martin107 CreditAttribution: martin107 as a volunteer commented
FileSize
2969549-9.patch20.74 KB
interdiff-2969549-8-9.txt541 bytes

I will describe part of my review process.

When I look at the passing test results from #8 -- the test result is stored here.

https://www.drupal.org/pift-ci-job/956884

In that I see :-

1 coding standards message
✗ 1 more than branch result

So I see one tiny aspect to correct.

Otherwise the patch looks good and I think this is ready to go.

Also here is the guide on producing an interdiff.

https://www.drupal.org/documentation/git/interdiff

amateescu’s picture

amateescu CreditAttribution: amateescu for Pfizer, Inc. commented
Status: Needs review » Reviewed & tested by the community

Looks great now, thanks @marcel66 and @martin107!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott as a volunteer and at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Fixed

Committed 84d5e36 and pushed to 8.6.x. Thanks!

  • alexpott committed 84d5e36 on 8.6.x 
    Issue #2969549 by marcel66, martin107: Fix "The $published parameter is...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

jonathan1055’s picture

jonathan1055 CreditAttribution: jonathan1055 as a volunteer commented

Hi,
The deprecation message text "The $published parameter is deprecated since version 8.3.x and will be removed in 9.0.0" does not make it helpful for developers to find what is actually causing the warning. There is no mention of the actual function called, hence I had to search for this text in the source code. Is it possble to add 'setPublished() and setUnpublished()' into the message, so that it gives some idea of where to start searching.
Thanks
Jonathan
ps. I know this issue is closed, but not sure where better to make this request.