Core should have a drupalci.yml to drive the build. Lets add one here that doesnt change the current testing behavior, and debate the merits of new build control features on the parent issue.

#2951843: Use drupalci.yml to fail test runs early

CommentFileSizeAuthor
#4 2969363_add-drupalci-yml_4.patch2.29 KBMixologic
#4 interdiff.txt521 bytesMixologic
#2 2969363_add-drupalci-yml_2.patch2.29 KBMixologic
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Mixologic created an issue. See original summary.

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
CreditAttribution: Mixologic at Drupal Association commented
Status: Active » Needs review
FileSize
2969363_add-drupalci-yml_2.patch2.29 KB
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner at Chapter Three commented
Category: Feature request » Task

Thank you @Mixologic to open up a quick win issue :)

+++ b/core/drupalci.yml
@@ -0,0 +1,57 @@
+      # run_tests task is executed several times in order of performance speeds.
+      # halt-on-fail is set on the run_tests tasks in order to fail fast.
+      # suppress-deprecations is false in order to be alerted to usages of
+      # deprecated code.

I guess this comment is now out of date

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
CreditAttribution: Mixologic at Drupal Association commented
FileSize
interdiff.txt521 bytes
2969363_add-drupalci-yml_4.patch2.29 KB

How about we tweak it to say 'can be' instead of 'is' to indicate what those flags are used for?

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner at Chapter Three commented
Status: Needs review » Reviewed & tested by the community

Good idea. Works for me :)

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: 2969363_add-drupalci-yml_4.patch, failed testing. View results

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner at Chapter Three commented
Status: Needs work » Reviewed & tested by the community

back to RTBC

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce commented

Crediting @dawehner.

alexpott credited Mile23.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce commented

Crediting @Mile23 because I'm pretty sure they have been involved in implementing the drupalci.yml

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce commented
Status: Reviewed & tested by the community » Fixed

Committed c44d82d and pushed to 8.6.x. Thanks!

Only adding to 8.6.x just in case there are issues we don't know about.

  • alexpott committed c44d82d on 8.6.x 
    Issue #2969363 by Mixologic, dawehner, Mile23: Add a drupalci.yml to...
Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
CreditAttribution: Mixologic at Drupal Association commented

Great!

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 commented

Thanks for the credit, @alexpott.

And just as we got this in, we also have this change to the testbot: #2971239: Invert build to create environment first

So here's a follow-up about it: #2974033: drupalci.yml no longer needs to re-run composer install

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.