Problem/Motivation

Add test of the product display type source plugin.

Proposed resolution

Write the tests.

Remaining tasks

Patch
review
commit

CommentFileSizeAuthor
#2 2966208-2.patch9.41 KBquietone
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone CreditAttribution: quietone at Acro Commerce commented
Status: Active » Needs review
FileSize
2966208-2.patch9.41 KB

Add test and a field to fields().

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Acro Commerce commented
Issue summary: View changes
Status: Needs review » Needs work 
+++ b/modules/commerce/tests/src/Kernel/Plugin/migrate/source/d7/ProductDisplayTypeTest.php
@@ -0,0 +1,134 @@
+    $tests[0]['expected_data'] = [
+      [
+        'type' => 'tops',
+        'name' => 'Tops',
+        'field_name' => 'field_product',
+        'description' => 'Shirts',
+        'help' => '',

I think it would be good to have tests of more than one node in here so we can see how things get filtered (or not) when coming from the source plugin.

quietone’s picture

quietone CreditAttribution: quietone at Acro Commerce commented
Status: Needs work » Needs review

Do you mean node type? The source data does not include node data but it does have data for 2 nodes types,

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Acro Commerce commented
Status: Needs review » Reviewed & tested by the community

I missed that. Tests look good.

  • heddn committed 9f3c40a on 8.x-2.x authored by quietone 
    Issue #2966208 by quietone, heddn: Add product display type source...
heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Acro Commerce commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.