TestingParty08: comment block [#296482]

Comment	File	Size	Author
#1	296482_1_recent-comments-block.patch	1.32 KB	mr.baileys

Comment #1

mr.baileys

Dutch

🇧🇪 (Ghent)

CreditAttribution: mr.baileys commented 6 March 2009 at 09:56

Component:

tests

» comment.module

File	Size
296482_1_recent-comments-block.patch	1.32 KB

The following cases seem to be already covered by the current comment.test (in testRecentCommentBlock):

Verify that the block is available
Test setting the block title and comment count
Verify that users with "access comments" permission can see the block
Verify that users without the "access comments" permission cannot see the block
Verify that the number of comments shown is <= than the comment count setting

The only case missing IMO is verifying that all comments are shown if number of comments >= comment count setting. Patch attached to add this test case.

Log in or register to post comments

Comment #2

mr.baileys

Dutch

🇧🇪 (Ghent)

CreditAttribution: mr.baileys commented 6 March 2009 at 09:57

Status:

Active

» Needs review

Log in or register to post comments

Comment #3

9 March 2009 at 12:30

Status:

Needs review

» Needs work

The last submitted patch failed testing.

Log in or register to post comments

Comment #4

mr.baileys

Dutch

🇧🇪 (Ghent)

CreditAttribution: mr.baileys commented 10 March 2009 at 07:06

Status:

Needs work

» Needs review

re-test.

Log in or register to post comments

Comment #5

13 March 2009 at 08:10

Status:

Needs review

» Needs work

The last submitted patch failed testing.

Log in or register to post comments

Comment #6

mr.baileys

Dutch

🇧🇪 (Ghent)

CreditAttribution: mr.baileys commented 13 March 2009 at 10:33

Status:

Needs work

» Needs review

At first sight, this change is unrelated to the failed test (GD image library), and patch passed tests succesfully ealier, so re-testing to see if we can make the bot happy.