I thought that there was an automatic spell checker; I'm not sure how this was missed and whether I should be filing this under a different META issue.
In hook_queue_info_alter docblock. There is a typo processesed. Also there is a incorrect @see \Drupal\Core\QueueWorker\QueueWorkerInterface which should be \Drupal\Core\Queue\QueueWorkerInterface

CommentFileSizeAuthor
#9 fix_typos_in_core.api_.php-2962961-9.patch2.2 KBvegantriathlete
#9 interdiff-8-9.txt1.05 KBvegantriathlete
#5 fix_typos_in_core.api_.php-2962961-5.patch1.28 KBvegantriathlete
#5 interdiff-2-5.txt665 bytesvegantriathlete
#2 misspelled_word-2962961-2.patch771 bytesvegantriathlete
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vegantriathlete created an issue. See original summary.

vegantriathlete’s picture

vegantriathlete
he/him/his
Primary language English
Location Lakewood, CO
CreditAttribution: vegantriathlete as a volunteer commented
Status: Active » Needs review
FileSize
misspelled_word-2962961-2.patch771 bytes

patch attached!

msankhala’s picture

msankhala CreditAttribution: msankhala as a volunteer and at Srijan | A Material+ Company commented
Title: Misspelled word in core.api.php » Fix typos in core.api.php and correct incorrect @see

@vegantriathlete Patch looks good. I had a quick look at core.api.php. There are few more things which can be fixed. I think that can be part of this patch.

In hook_queue_info_alter docblock. There is a typo processesed. Also there is a incorrect @see \Drupal\Core\QueueWorker\QueueWorkerInterface which should be \Drupal\Core\Queue\QueueWorkerInterface

msankhala’s picture

msankhala CreditAttribution: msankhala as a volunteer and at Srijan | A Material+ Company commented
Status: Needs review » Needs work
vegantriathlete’s picture

vegantriathlete
he/him/his
Primary language English
Location Lakewood, CO
CreditAttribution: vegantriathlete as a volunteer commented
Status: Needs work » Needs review
FileSize
interdiff-2-5.txt665 bytes
fix_typos_in_core.api_.php-2962961-5.patch1.28 KB

@msankhala: Thanks for the suggestions!

msankhala’s picture

msankhala CreditAttribution: msankhala as a volunteer and at Srijan | A Material+ Company commented
Status: Needs review » Reviewed & tested by the community

Good work @vegantriathlete. This patch applies cleanly.

msankhala’s picture

msankhala CreditAttribution: msankhala as a volunteer and at Srijan | A Material+ Company commented
Issue summary: View changes
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Thunder commented
Status: Reviewed & tested by the community » Needs work

There are 2 other things to fix if we are fixing up this file.
There's also \Drupal\Core\Cache\CacheableDepenencyInterface::getCacheTags(),
timespan should also be time span - whilst we do have timespan in core it is referring to a timespan field and this is not. We have over usages of time span in core.

Plus, we should open a follow up to convert all datatypes to be data types. Again there is datatypes in core but the usage of data types far outweighs it (even in core.api.php).

vegantriathlete’s picture

vegantriathlete
he/him/his
Primary language English
Location Lakewood, CO
CreditAttribution: vegantriathlete as a volunteer commented
Status: Needs work » Needs review
FileSize
interdiff-8-9.txt1.05 KB
fix_typos_in_core.api_.php-2962961-9.patch2.2 KB
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented
Status: Needs review » Reviewed & tested by the community

#9 fixes @alexpott's remarks, back to RTBC. We still need to file that followup though.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Thunder commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 91c29aea1d to 8.6.x and 6d4a847b0a to 8.5.x. Thanks!

Credited @msankhala and myself for reviews that directly influenced the patch.

  • alexpott committed 91c29ae on 8.6.x 
    Issue #2962961 by vegantriathlete, msankhala, alexpott: Fix typos in...

  • alexpott committed 6d4a847 on 8.5.x 
    Issue #2962961 by vegantriathlete, msankhala, alexpott: Fix typos in...
vegantriathlete’s picture

vegantriathlete
he/him/his
Primary language English
Location Lakewood, CO
CreditAttribution: vegantriathlete as a volunteer commented
Related issues: +#2972835: Switch datatypes to data types

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.