Update from 4.8.0 (well, 4.8.0+2018-04-18-security-patch, per https://www.drupal.org/sa-core-2018-003) to CKEditor 4.9.2: https://ckeditor.com/blog/CKEditor-4.9-released/

4.9.x contains a whole lot of bugfixes: https://ckeditor.com/cke4/release/CKEditor-4.9.0 + https://ckeditor.com/cke4/release/CKEditor-4.9.1 + https://ckeditor.com/cke4/release/CKEditor-4.9.2. It also includes new features, but we're not enabling any of those — that's out of scope for this issue. One new feature we get for free though: #1338: Keystroke labels are displayed for function keys (like F7, F8).

4.9.0 did not ship with Drupal 8.5.0, because 8.5.0 was tagged March 7, whereas 4.9.0 was tagged March 14.

(4.9.2 is a security release, but its security patch was already backported to CKEditor 4.8.x. Again, see https://www.drupal.org/sa-core-2018-003.)

See also:

#1858210: [meta] Content editing experience follow-ups — in-place editing and WYSIWYG
#1950098: Update CKEditor library to 4.1
#2036253: Update CKEditor library to 4.2
#2039163: Update CKEditor library to 4.4
#2271051: Update CKEditor library to 4.4.4
#2345961: Update CKEditor library to 4.4.5
#2384581: Security: Update CKEditor library to 4.4.6
#2415111: Update CKEditor library to 4.4.7
#2521820: Update CKEditor library to 4.5.3
#2321583: Update CKEditor library to 4.5.5
#2663566: Update CKEditor library to 4.5.7
#2698587: Update CKEditor library to 4.5.8
#2724225: Update CKEditor library to 4.5.9
#2765751: Update CKEditor library to 4.5.10
#2797427: Update CKEditor library to 4.5.11
#2828494: Update CKEditor library to 4.6
#2848215: Update CKEditor library to 4.6.2
#2893566: Update CKEditor library to 4.7.1
#2904142: Update CKEditor library to 4.7.2
#2908864: Update CKEditor library to 4.7.3
#2926932: Update CKEditor library to 4.8.0

CommentFileSizeAuthor
#2 2962330-2.patch3.18 MBWim Leers
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Wim Leers created an issue. See original summary.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Assigned: Wim Leers » Unassigned
Status: Active » Needs review
FileSize
2962330-2.patch3.18 MB

And … patch!

cilefen’s picture

cilefen CreditAttribution: cilefen at Institute for Advanced Study commented

#2962352: Core 8.5.2 breaks webforms.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Related issues: +#2962352: Core 8.5.2 breaks webforms.
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Status: Needs review » Reviewed & tested by the community

I tested the patch manually. I tried to test all the different buttons available, including configuration for styles and languages and the buttons, as well as our dialog integration, image upload, table builder. 🕵️‍♂️ During the process I also went through our CKEditor integration to learn more about our customizations to make sure that I know which parts to test. As far as I can tell, everything in core is working as supposed to. 🚀

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented

Crediting @lauriii for a thorough review and test with a comment that outlines the steps taken.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Fixed

Committed 657cdcd and pushed to 8.6.x. Thanks!

  • alexpott committed 657cdcd on 8.6.x 
    Issue #2962330 by Wim Leers, lauriii: Update CKEditor library to 4.9.2
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented

🎉

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.