Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
#2297685: Edit URI for remote files introduced a regression for us that prevents us from saving media entities.
It results in an error as a form_set_errror() when no provider can be found, which I think is absolutely expected for a local image for example.
Proposed resolution
Not sure, just silently skip if no provider can be found instead of showing an error?
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | media-internet-remove-error-2961667-2.patch | 600 bytes | Berdir |
| |||
Comments
Comment #2
BerdirHaving to throw/catch an exception is still bad design IMHO but at least the error is gone.
Comment #3
joseph.olstadInstead lets revert 2297685
Comment #4
BerdirWorks for me too, but it's already in a release, so it's functionality that will then be gone again, so some users might be unhappy about that ;)
Comment #9
joseph.olstadyes , the patch is still available in the other issue.
Maybe Chris Goss can fix the patch.
there's a lot of different ways media_internet is used by various other contrib modules so maybe not as simple as we thought at first glance.
I can think of media_youtube and media_oembed and media_vimeo for example.
Comment #10
joseph.olstadI will tag a new release right away.
Comment #11
joseph.olstadRemoved the said regression from all branches.
media 2.18 released
media 7.x-3.0-rc4 released
media 7.x-4.0-alpha3 released