We need to port the D7 feeds_tamper HTML Entity Encode plugin to D8 tamper.

CommentFileSizeAuthor
#6 htmlentityencode-2960837-6.patch2.28 KBericgsmith
#6 interdiff-2960837-5-6.txt2.33 KBericgsmith
#5 interdiff_3-5.txt3.3 KBjamesdixon
#5 htmlentityencode-2960837-5.patch1.89 KBjamesdixon
#3 interdiff_2-3.txt1.38 KBjamesdixon
#3 htmlentityencode-2960837-3.patch1.93 KBjamesdixon
#2 htmlentityencode-2960837-2.patch2.48 KBjamesdixon
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jamesdixon created an issue. See original summary.

jamesdixon’s picture

jamesdixon CreditAttribution: jamesdixon commented
Status: Active » Needs review
FileSize
htmlentityencode-2960837-2.patch2.48 KB

Here's a first draft of the D8 tamper HTML Entity Decode plugin. Thanks for your review.

jamesdixon’s picture

jamesdixon CreditAttribution: jamesdixon commented
FileSize
htmlentityencode-2960837-3.patch1.93 KB
interdiff_2-3.txt1.38 KB

Last patch has been updated with @ericgsmith's suggestions. Now I can move onto others!

ericgsmith’s picture

ericgsmith CreditAttribution: ericgsmith as a volunteer commented
Status: Needs review » Needs work

Thanks James - same comments as per https://www.drupal.org/project/tamper/issues/2960830

  1. +++ b/src/Plugin/Tamper/HTMLEntityEncode.php
@@ -0,0 +1,34 @@
+use Drupal\Core\Form\FormStateInterface;

    Unused - can remove 

  2. +++ b/src/Plugin/Tamper/HTMLEntityEncode.php
@@ -0,0 +1,34 @@
+class HTMLEntityEncode extends TamperBase {

    Camel case for class name.

jamesdixon’s picture

jamesdixon CreditAttribution: jamesdixon at Dialed In Design commented
Status: Needs work » Needs review
FileSize
htmlentityencode-2960837-5.patch1.89 KB
interdiff_3-5.txt3.3 KB

Thanks for the suggestions. I have included them in the latest patch.

ericgsmith’s picture

ericgsmith CreditAttribution: ericgsmith as a volunteer commented
FileSize
interdiff-2960837-5-6.txt2.33 KB
htmlentityencode-2960837-6.patch2.28 KB

Thanks James - just re rolling the test against the new base class.

ericgsmith’s picture

ericgsmith CreditAttribution: ericgsmith as a volunteer commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.