Problem/Motivation

OptionsRequestSubscriber uses call_user_func_array() unnecessarily.

Proposed resolution

Remove call_user_func_array(). This event subscriber is fully tested in OptionsRequestSubscriberTest

Remaining tasks

User interface changes

None

API changes

None

Data model changes

CommentFileSizeAuthor
#3 event.png9.89 KBchanderbhushan
#2 2960507-2.patch1.12 KBalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce commented
Status: Active » Needs review
FileSize
2960507-2.patch1.12 KB
chanderbhushan’s picture

chanderbhushan CreditAttribution: chanderbhushan as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented
FileSize
event.png9.89 KB

@alexpott, I have tested your patch. working fine.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner at Chapter Three commented
Status: Needs review » Reviewed & tested by the community

Too bad we cannot use ..., given this could be used instead, too.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 2960507-2.patch, failed testing. View results

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
CreditAttribution: Mixologic at Drupal Association commented
Status: Needs work » Reviewed & tested by the community

Testbot Snafu.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Priority: Normal » Minor

👌

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed e74d54b and pushed to 8.6.x. Thanks!

  • catch committed e74d54b on 8.6.x 
    Issue #2960507 by alexpott: Remove call_user_func_array from...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.