Problem/Motivation

To reproduce this issue:

git checkout 8.4.0 && composer install
drush si standard -y
drush en content_moderation -y
git checkout 8.6.x && composer install
drush updb
[notice] Update started: content_moderation_post_update_update_cms_default_revisions
[warning] array_shift() expects parameter 1 to be array, null given content_moderation.post_update.php:37
[ok] Update completed: content_moderation_post_update_update_cms_default_revisions

This is annoying because it prevents us from being able to use drupal-8.4.0.bare.standard.php.gz and drupal-8.4.0-content_moderation_installed.php together without an error being triggered. This is a blocker for #2949964: Add an EntityOwnerTrait to standardize the base field needed by EntityOwnerInterface.

Proposed resolution

Fix the post_update hook to work when no entity types are being moderated.

Remaining tasks

User interface changes

API changes

Data model changes

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Sam152 created an issue. See original summary.

Sam152’s picture

Issue summary: View changes
Sam152’s picture

Status: Active » Needs review
FileSize
1.81 KB
2.61 KB

The last submitted patch, 3: 2960054-3_TEST-ONLY.patch, failed testing. View results

timmillwood’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +Workflow Initiative

Nice find @Sam152.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Nice find and elegant test.

Committed and pushed 7e11010140 to 8.6.x and 00da00b4c7 to 8.5.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.