Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
To reproduce this issue:
git checkout 8.4.0 && composer install
drush si standard -y
drush en content_moderation -y
git checkout 8.6.x && composer install
drush updb
[notice] Update started: content_moderation_post_update_update_cms_default_revisions
[warning] array_shift() expects parameter 1 to be array, null given content_moderation.post_update.php:37
[ok] Update completed: content_moderation_post_update_update_cms_default_revisions
This is annoying because it prevents us from being able to use drupal-8.4.0.bare.standard.php.gz
and drupal-8.4.0-content_moderation_installed.php
together without an error being triggered. This is a blocker for #2949964: Add an EntityOwnerTrait to standardize the base field needed by EntityOwnerInterface.
Proposed resolution
Fix the post_update hook to work when no entity types are being moderated.
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#3 | 2960054-3.patch | 2.61 KB | Sam152 |
#3 | 2960054-3_TEST-ONLY.patch | 1.81 KB | Sam152 |
Comments
Comment #2
Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commentedComment #3
Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commentedComment #5
timmillwoodNice find @Sam152.
Comment #6
alexpottNice find and elegant test.
Committed and pushed 7e11010140 to 8.6.x and 00da00b4c7 to 8.5.x. Thanks!