We have to convert the module to short array syntax as per new coding.

CommentFileSizeAuthor
#9 2958087-shortarray-reroll-9.patch5.59 KBgreggles
#2 short-syntax-array-Convert-2958087-8.x-1.x-dev-2.patch6.18 KBPrashant.c
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Prashant.c created an issue. See original summary.

Prashant.c’s picture

Prashant.c
he/him
Primary language English
Location Dharamshala
CreditAttribution: Prashant.c as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented
Status: Active » Needs review
FileSize
short-syntax-array-Convert-2958087-8.x-1.x-dev-2.patch6.18 KB
Prashant.c’s picture

Prashant.c
he/him
Primary language English
Location Dharamshala
CreditAttribution: Prashant.c as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented
Title: Convert module to use short array syntax (new coding standard). Primary tabs View(active tab) » Convert module to use short array syntax (new coding standard)
nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
CreditAttribution: nkoporec as a volunteer and at Agiledrop - Your Trusted Drupal Teammates commented
Status: Needs review » Reviewed & tested by the community

Tested the patch and it applies cleanly, also it works as expected.Marking this as RTBC.

Prashant.c’s picture

Prashant.c
he/him
Primary language English
Location Dharamshala
CreditAttribution: Prashant.c as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented

Any updates on this still in RTBC ?

D4K0’s picture

D4K0 CreditAttribution: D4K0 as a volunteer commented

Check out this issue.
This patch by brathje resolves the wrong variable name ($conf -> $settings) and the text issue in README.txt.

Applying brathje's patch we could kill two birds with one stone...

D4K0’s picture

D4K0 CreditAttribution: D4K0 as a volunteer commented
Status: Reviewed & tested by the community » Needs work
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented

Would be great to get this in after #2864902: Update "e-mail" to "email" across all files & #2909161: Wrong custom string example because will make most of patches outdated

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles at Morris Animal Foundation commented
Status: Needs work » Needs review
FileSize
2958087-shortarray-reroll-9.patch5.59 KB

Here's a re-roll after applying #2864902: Update "e-mail" to "email" across all files. I also excluded the README change so that can be fixed in 2909161.

  • greggles committed 0b3c0d4 on 8.x-1.x authored by Prashant.c 
    Issue #2958087 by Prashant.c, greggles, nkoporec: Convert module to use...
greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles at Morris Animal Foundation commented
Status: Needs review » Fixed

OK, now committed. This should reduce the risk for having to reroll in the near future.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.