Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
While trying to write the test case for #2917917: Change title for create action and edit action routes. I noticed the missing help message when adding a new action and incorrect help message when editing action. For example, Add and Edit screen of "Redirect to URL" action.
Add action screen:
Whilst there is a mistake in the help message. Help message refers to Description field while there is no Description field on that screen. It should refer to Label field.
Edit action screen:
Proposed resolution
- I think it is a good idea to show same help message when adding new action because help message recommends editing the
Label
field. - Update the help message to refer to the Label field instead of the Description field.
Remaining tasks
Write patch.
User interface changes
- Make correction in help message.
- Display help message on add action screen as well.
API changes
N/A
Data model changes
N/A
Comment | File | Size | Author |
---|---|---|---|
#2 | add-edit-action-screens-help-message-2956381-2.patch | 1.37 KB | msankhala |
edit-action-screen.png | 203.5 KB | msankhala | |
add-action-screen.png | 193.55 KB | msankhala |
Comments
Comment #2
msankhala CreditAttribution: msankhala as a volunteer and at Srijan | A Material+ Company commentedComment #3
msankhala CreditAttribution: msankhala as a volunteer and at Srijan | A Material+ Company commentedComment #4
msankhala CreditAttribution: msankhala as a volunteer and at Srijan | A Material+ Company commentedCreated a somewhat related issue #2956385: Use route provider for action entities
Comment #5
msankhala CreditAttribution: msankhala as a volunteer and at Srijan | A Material+ Company commentedStill waiting for review.
Comment #6
borisson_I'm not sure if this belong in the action.module or in the documentation component. The changes look good though.
Comment #7
msankhala CreditAttribution: msankhala as a volunteer and at Srijan | A Material+ Company commentedI think this relates to action.module component because changes are in actual code not in the documentation.
Comment #8
nkoporecTested the patch and it's looking good.Nice job!
Comment #9
msankhala CreditAttribution: msankhala as a volunteer and at Srijan | A Material+ Company commentedComment #10
msankhala CreditAttribution: msankhala as a volunteer and at Srijan | A Material+ Company commented@nkoporec Can you move this to RTBC then?
Comment #11
nkoporec@msankhala let's just wait a bit, so other people can review it too.
Comment #12
borisson_Looks good.
Comment #14
MixologicTestbot Snafu.
Comment #16
bibliophileaxeTestbot issue.
Comment #17
alexpottSo we don't break translations in a bugfix release only committing to 8.6.0. Since this is an actual bugfix one of the release managers might decide that we can backport this to 8.5.x
Committed a14ec58 and pushed to 8.6.x. Thanks!