Problem/Motivation

While trying to write the test case for #2917917: Change title for create action and edit action routes. I noticed the missing help message when adding a new action and incorrect help message when editing action. For example, Add and Edit screen of "Redirect to URL" action.

Add action screen:
Add action screen

Whilst there is a mistake in the help message. Help message refers to Description field while there is no Description field on that screen. It should refer to Label field.

Edit action screen:
Edit action screen

Proposed resolution

  1. I think it is a good idea to show same help message when adding new action because help message recommends editing the Label field.
  2. Update the help message to refer to the Label field instead of the Description field.

Remaining tasks

Write patch.

User interface changes

  1. Make correction in help message.
  2. Display help message on add action screen as well.

API changes

N/A

Data model changes

N/A

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

msankhala created an issue. See original summary.

msankhala’s picture

Status: Active » Needs review
FileSize
1.37 KB
msankhala’s picture

Issue summary: View changes
msankhala’s picture

msankhala’s picture

Still waiting for review.

borisson_’s picture

I'm not sure if this belong in the action.module or in the documentation component. The changes look good though.

msankhala’s picture

I think this relates to action.module component because changes are in actual code not in the documentation.

nkoporec’s picture

Tested the patch and it's looking good.Nice job!

msankhala’s picture

Issue summary: View changes
msankhala’s picture

@nkoporec Can you move this to RTBC then?

nkoporec’s picture

@msankhala let's just wait a bit, so other people can review it too.

borisson_’s picture

Status: Needs review » Reviewed & tested by the community

Looks good.

Status: Reviewed & tested by the community » Needs work
Mixologic’s picture

Status: Needs work » Reviewed & tested by the community

Testbot Snafu.

Status: Reviewed & tested by the community » Needs work
bibliophileaxe’s picture

Status: Needs work » Reviewed & tested by the community

Testbot issue.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed
Issue tags: +String change in 8.6.0

So we don't break translations in a bugfix release only committing to 8.6.0. Since this is an actual bugfix one of the release managers might decide that we can backport this to 8.5.x

Committed a14ec58 and pushed to 8.6.x. Thanks!

  • alexpott committed a14ec58 on 8.6.x
    Issue #2956381 by msankhala: Missing help message when adding new action...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.