Provide a backport to Drupal 7 of the base_form_id targeting functionality introduced in #2839891: Allow to target the base_form_id

CommentFileSizeAuthor
#5 captcha-allow_base_form_id_captcha_point-2955343-5.patch2.69 KBpvdjay
#2 captcha-allow_base_form_id_captcha_point-2955343-2.patch2.62 KBpvdjay
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jayusa123 created an issue. See original summary.

pvdjay’s picture

pvdjay CreditAttribution: pvdjay as a volunteer commented
Status: Active » Needs review
FileSize
captcha-allow_base_form_id_captcha_point-2955343-2.patch2.62 KB

Status: Needs review » Needs work

The last submitted patch, 2: captcha-allow_base_form_id_captcha_point-2955343-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

alexharries’s picture

alexharries CreditAttribution: alexharries commented

Subscribing - this would be very helpful to have :)

pvdjay’s picture

pvdjay CreditAttribution: pvdjay as a volunteer commented
Status: Needs work » Needs review
FileSize
captcha-allow_base_form_id_captcha_point-2955343-5.patch2.69 KB

Fixed bug identified in automated test.

Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews as a volunteer commented
Issue summary: View changes
Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews as a volunteer commented
Assigned: pvdjay » Unassigned
Status: Needs review » Reviewed & tested by the community

The patch in #5 applied cleanly to the latest captcha 7.x-1.x-dev and works great for me.

Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews as a volunteer commented
Parent issue: » #3032542: Plan for CAPTCHA 7.x-1.6 release
wundo’s picture

wundo CreditAttribution: wundo at Chuva Inc. for Galoa Science commented
Parent issue: #3032542: Plan for CAPTCHA 7.x-1.6 release » #3086055: Plan for CAPTCHA 7.x-1.7 release
wundo’s picture

wundo CreditAttribution: wundo at Chuva Inc. for Galoa Science commented
wundo’s picture

wundo CreditAttribution: wundo at Chuva Inc. for Galoa Science commented
Status: Reviewed & tested by the community » Fixed

  • wundo committed 5f1b2ca on 7.x-1.x authored by pvdjay 
    Issue #2955343 by pvdjay, Chris Matthews, wundo, alexharries: Backport...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.