The readme file does not follow Drupal standards
https://www.drupal.org/docs/develop/documenting-your-project/readme-template

CommentFileSizeAuthor
#7 queue_order_d8-2955285-7.patch2.55 KBvoleger
#7 interdiff-2955285-05-07.txt457 bytesvoleger
#6 interdiff-2955285-04-05.txt1.96 KBvoleger
#6 queue_order_d8-2955285-5.patch2.56 KBvoleger
#4 queue_order_d8-2955285-4.patch2.69 KBMaheshwaran.j
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

voleger created an issue. See original summary.

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
CreditAttribution: voleger as a volunteer and at GOLEMS GABB, Drupal Ukraine Community for GOLEMS GABB, Drupal Ukraine Community commented
Parent issue: » #2951896: [D8] Queue Order
Maheshwaran.j’s picture

Maheshwaran.j CreditAttribution: Maheshwaran.j as a volunteer and at DrupalPartners for Innoppl Technologies Pvt. Ltd commented
Assigned: voleger » Maheshwaran.j
Maheshwaran.j’s picture

Maheshwaran.j CreditAttribution: Maheshwaran.j as a volunteer and at DrupalPartners for Innoppl Technologies Pvt. Ltd commented
Assigned: Maheshwaran.j » Unassigned
Status: Needs work » Needs review
Issue tags: +Documentation, +README.txt
FileSize
queue_order_d8-2955285-4.patch2.69 KB

Hi Voleger

Here is a patch for readme.md file.

akash.addweb’s picture

akash.addweb CreditAttribution: akash.addweb commented
Status: Needs review » Needs work

@Maheshwaran.j, Your patch updates the ReadMe but still, there are some issues which needs to be corrected in next patch, i.e.
1) Need to add one more line of a gap above the 'yaml' section
2) Text manually word-wrapped within around 80 cols.
Also, you can refer https://www.drupal.org/docs/develop/documenting-your-project/readme-temp... for more.

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
CreditAttribution: voleger as a volunteer and at GOLEMS GABB, Drupal Ukraine Community for GOLEMS GABB, Drupal Ukraine Community commented
FileSize
queue_order_d8-2955285-5.patch2.56 KB
interdiff-2955285-04-05.txt1.96 KB

Hi Maheshwaran.j !

Thanks for the patch.
Added line breaks for the long lines.

Feel free to leave the comments if there need some changes.
For me, it looks good.
So if there need no other changes I'll merge it into dev branch and later prepare a new release with latest changes.

Update:
Hi Ronak.addweb !
thanks for the review.

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
CreditAttribution: voleger as a volunteer and at GOLEMS GABB, Drupal Ukraine Community for GOLEMS GABB, Drupal Ukraine Community commented
Status: Needs work » Needs review
FileSize
interdiff-2955285-05-07.txt457 bytes
queue_order_d8-2955285-7.patch2.55 KB
voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
CreditAttribution: voleger as a volunteer and at GOLEMS GABB, Drupal Ukraine Community for GOLEMS GABB, Drupal Ukraine Community commented

update creds

Maheshwaran.j’s picture

Maheshwaran.j CreditAttribution: Maheshwaran.j as a volunteer and at DrupalPartners for Innoppl Technologies Pvt. Ltd commented
Status: Needs review » Reviewed & tested by the community

Hi voleger

This looks good. You can go ahead and commit the patch.

  • voleger committed b18a09e on 8.x-1.x authored by Maheshwaran.j 
    Issue #2955285 by voleger, Maheshwaran.j, Ronak.addweb: Update README...
voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
CreditAttribution: voleger as a volunteer and at GOLEMS GABB, Drupal Ukraine Community for GOLEMS GABB, Drupal Ukraine Community commented
Status: Reviewed & tested by the community » Fixed

Thanks, fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.