Fix ::label() logic and add a ParagraphInterface::getOrphanStatus() helper

The missing t() is accidental.

1. +++ b/src/Entity/Paragraph.php
   @@ -134,16 +134,28 @@ class Paragraph extends ContentEntityBase implements ParagraphInterface {
        if ($parent = $this->getParentEntity()) {
          $parent_field = $this->get('parent_field_name')->value;
   +      /** @var \Drupal\entity_reference_revisions\EntityReferenceRevisionsFieldItemList $values */
          $values = $parent->{$parent_field};
   

   While working on this, lets also make sure that we add an hasField() check. and mabe include the summary in the orphaned fallback label, like "Orphaned @type: @first_20_characters_of_summary" or so.

2. +++ b/src/Entity/Paragraph.php
   @@ -134,16 +134,28 @@ class Paragraph extends ContentEntityBase implements ParagraphInterface {
   +        $previous_revision = TRUE;
   +        foreach ($values as $value) {
   +          if ($value->entity->id() == $this->id()) {
   +            $previous_revision = FALSE;
   +            $label = $parent->label() . ' > ' . $value->getFieldDefinition()->getLabel();
   +            break;
   +          }
   +        }
   

   I would invert it and do an early return inside the foreach if have a match. Then you can drop the if/else and just return the fallback title if the foreach never matched.

   And yes, both variants should use t() with placeholders and not just combine the strings together.

3. +++ b/tests/src/Functional/ParagraphsLabelTest.php
   @@ -0,0 +1,77 @@
   +class ParagraphsLabelTest extends BrowserTestBase {
   

   Can't we make this a kernel test, I don't think this contains anything that is UI relevant and a kernel test would be a lot faster.

1. On the other hand, 1) the orphaned stuff is hopefully temporary, so lets not do too much there, feel free to skip that.

To be clear, I just meant that a better label for a completely orphaned label might not be needed, as the goal is to prevent that from happening, Non-default revision is still useful, as it knowing what the status is.

+++ b/src/Entity/Paragraph.php
@@ -134,20 +136,73 @@ class Paragraph extends ContentEntityBase implements ParagraphInterface {
+      ->condition($parent->getEntityType()->getKey('id'), $parent->id())

This is a wrong condition.

A Paragraph could be moved with drag & drop from one parent host to some other. A previous revision of a previous parent would point to the paragraphs entity, but the parent id would have changed.

Wohoo, the key problem here is that these base fields are not revisionable...

    $fields['parent_id'] = BaseFieldDefinition::create('string')
      ->setLabel(t('Parent ID'))
      ->setDescription(t('The ID of the parent entity of which this entity is referenced.'))
      ->setSetting('is_ascii', TRUE);

    $fields['parent_type'] = BaseFieldDefinition::create('string')
      ->setLabel(t('Parent type'))
      ->setDescription(t('The entity parent type to which this entity is referenced.'))
      ->setSetting('is_ascii', TRUE)
      ->setSetting('max_length', EntityTypeInterface::ID_MAX_LENGTH);

    $fields['parent_field_name'] = BaseFieldDefinition::create('string')
      ->setLabel(t('Parent field name'))
      ->setDescription(t('The entity parent field name to which this entity is referenced.'))
      ->setSetting('is_ascii', TRUE)
      ->setSetting('max_length', FieldStorageConfig::NAME_MAX_LENGTH);

(And the parent pointer also doesn't point to the parent revision.)
That's where things fall apart.

This results in inability to simply query in revisions and figure out where the current paragraph is a child.
A workaround could be implemented (by looping and querying all paragraph fields) but that's not worth doing here.

Instead i would propose

• only support the case where the parent didn't change, by checking the target id only, not the parent id
• Document the status ORPHAN_STATUS_NOT_USED with a @todo as unreliable as a paragraph could report this status after moving from parent A to parent B and then deleting the field item (although it is still used in previous revisions of parent A).
• follow-up: Making them revisionable, investigate if we can reconstruct the history on update
• follow-up: Fix the orphan status so it can be reliably used for gc

Here is the same patch as #14 but against 1.3, for anyone who needs it.

@askibinski You removed use StringTranslationTrait; which causes the patch to fail. Attached a new patch!

That interdiff was supposed to be a .txt file obviously...

Here is the same patch as #17 but against the latest 8.x-1.x, for anyone who needs it.

Here's the same patch as #18 re-rolled against the latest version of 8.x-1.x-dev.

+++ b/src/Entity/Paragraph.php
@@ -139,20 +141,76 @@ class Paragraph extends ContentEntityBase implements ParagraphInterface {
+    $parent = $this->getParentEntity();

We do not have a real guarantee that a parent is always set. See also below early exit for getOrphanStatus()

Oh what happened with the tests from #17?

Let's add it back.

Refactored this (more accurately, started from scratch, so no interdiff), dropped the orphan API and just inlined the the checks. Did readd the tests and refactored them to only test label().

Very nice progress and clean test cases, thus committed.

Fixing the status