Adopt Content Moderation in Umami

@Eli-T,

I'm going to mark this as postponed for now, and let's revisit it asap once we get unhidden. I think this will make a great feature (and others are free to work on it in the meantime if they wish).

I am attaching the 'Umami new feature' tag to this item.

Related: #2983591: Add example.com email addresses to users created during Umami install

I didn't get the error reported in #2 when I used the patch. I suspect it was fixed in other issues.

The patch from #2 sets up the workflow but it wasn't enabled on the content type.

I've made a new patch that has the workflow enabled on article, page, and recipe content types.

I've looked through the permissions they all OK. Authors can create new content but not make it published, while editors can view content that hasn't been published and then publish it.

The admin screen need to be styled when viewing them with the Umami theme.

The content listing (/admin/content) needs styling. And the "Add content" button is missing, and the user needs to go to /node/add to add content.

The /node/*/edit page needs to be looked at. Especially the "Edit summary" link on the body field.

When viewing an unpublished node, the workflow form appears. This should also be styled.

I don't think we should expand the scope of this to the styling of the Umami theme as an admin theme. It is not an admin theme and we have not done any work on it to make it one.

Those issues - if we want to look at them - can be dealt with in follow up issues.

Setting to 'Needs work' so we can add permission for editor and author roles to use the admin theme.

@Eli-T - should we create a new issue for the workflow form styling? It's likely that the folks working on this issue will not be the same folks working on the CSS for that.

I think that sounds like a sensible approach - graceful degradation, let's call it!

It means we get this cool feature in sooner, and progressively enhance it later.

The patch from Eli-T in #16 prevents the need to style admin pages by letting the editors and authors view the admin theme.

The Moderation control form still appears, though. This is because it is set to be visible on the other view modes. Because of this, I'm setting this issue back to needs work.

Might be nice in a future release to allow authenticated users to post comments without approval, and to use the advanced search (just to show off how cool the permissions system is in drupal)

1. I agree to hide the moderation controls for now, but it would be really useful to reinstate it as it is a nice in-place experience where you can actually see what you are moderating as opposed to backend where the form chrome is distracting. Separate issue though. I created one at #2985551: Style and show content moderation form in Umami.

2. I think the approach taken here to add an author and editor roles is good. Adjusting authenticated user roles can also be a followup. I think moderator needs to be able to create draft from published as well, that permission is missing.

It would be nice to swiftly get this in and then work on perfecting the experience. For that the access fails needs to be resolved, the current fails seems to indicate there is a permission issue.

Some nitpicks, some followup:

1. +++ b/core/profiles/demo_umami/config/install/core.entity_form_display.block_content.footer_promo_block.default.yml
   @@ -56,4 +56,6 @@ content:
   -hidden: {  }
   +hidden:
   +  moderation_state: true
   +
   

   Extra newline

2. +++ b/core/profiles/demo_umami/config/install/core.entity_form_display.media.remote_video.default.yml
   @@ -14,7 +14,7 @@ mode: default
    content:
      created:
        type: datetime_timestamp
   -    weight: 10
   +    weight: 2
        region: content
        settings: {  }
        third_party_settings: {  }
   @@ -28,7 +28,7 @@ content:
   
   @@ -28,7 +28,7 @@ content:
        region: content
      path:
        type: path
   -    weight: 30
   +    weight: 3
        region: content
        settings: {  }
        third_party_settings: {  }
   @@ -36,12 +36,12 @@ content:
   
   @@ -36,12 +36,12 @@ content:
        type: boolean_checkbox
        settings:
          display_label: true
   -    weight: 100
   +    weight: 4
        region: content
        third_party_settings: {  }
      uid:
        type: entity_reference_autocomplete
   -    weight: 5
   +    weight: 1
        settings:
          match_operator: CONTAINS
          size: 60
   

   Let's leave these as-is. I can see how its re-weighted once saved, but for easier diffs with standard, it would be nice to keep as-is.

3. +++ b/core/profiles/demo_umami/config/install/user.role.author.yml
   @@ -0,0 +1,48 @@
   +  - 'create page content'
   ...
   +  - 'delete own page content'
   ...
   +  - 'edit own page content'
   ...
   +  - 'view page revisions'
   

   Normally I think page creation would be separate from article/recipe authoring, but it would be overkill to add even more roles, so this should be fine.

4. +++ b/core/profiles/demo_umami/config/install/user.role.author.yml
   @@ -0,0 +1,48 @@
   +  - 'create terms in tags'
   

   Last time I looked the terms widget did not allow to create new, so authors would need to go to a different UI to create the terms, this is super confusing.

   Also categories were chosen in a textfield rather than a dropdown. I think both of these are fixable as a standalone issue, just noting that giving authors the tag creation permission does not make them able to create tags if the widget does not allow them to :)

+++ b/core/profiles/demo_umami/config/install/user.role.author.yml
@@ -19,7 +19,6 @@
   - 'create terms in recipe_cuisine'
-  - 'create terms in tags'
   - 'create url aliases'

Erm, I did not suggest this to be removed?!

my bad, I misinterpret the suggestions in #27.

Hi @anmolgoyal74

The 'moderation state' widget needs to be positioned for each content type on the 'Manage Form Display' page, and the widget needs to be set as "moderation widget' not 'text field'.

When that is complete, I think this is ready for RTBC.

Added the moderation widget to article, recipe and page type.

Moving to RTBC.

Moderation form appears on node edit page:

Screenshot of article for an admin of an article with word "Updated" in title and article set to 'draft' state side by side with anonymous user version and title remaining at 'Published' state.

Yay looks good, thanks! I love that we have actual roles and users demonstrating moderation.