Closed (fixed)
Project:
Commerce Adyen
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Support request
Assigned:
Unassigned
Reporter:
Created:
12 Mar 2018 at 10:13 UTC
Updated:
2 Aug 2019 at 07:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
julien commentedHi,
The 8.x dev branch has been created and it is still in development.
Comment #3
pjeandenand commentedHi,
Is the 8.x dev branch up to date? We would like to help release the Commerce Adyen d8 version.
If not, could you please update the branch?
Best,
Pierre
Comment #4
vacho commentedWorking actively in this...
Comment #5
vacho commentedThis is the path I have drawn to complete this task.
1. Let edit/save the gateway (Done with this patch)
2. Let pay with gateway Boleto (Work in progress)
3. Let pay with gateway OpenInvoice (Work in progress)
I am still working with this but all comment and guide is welcome.
Comment #6
andypostComment #7
vacho commentedUpdating the progress in this patch
1. Let edit/save the gateway (Done with this patch)
2. Let pay with gateway Boleto (Work in progress)
3. Let pay with gateway OpenInvoice (Removed for now to complete later)
Advances:
4. Removed all code unnecessary inherited from D7
5. Move all Adyen API inside src folder for reuse it with correct namespaces for D8 (not composer dependencies)
6. Refactor code for plugin Boleto more friendly with commerce
Comment #8
vacho commentedUpdating the progress in this patch
1. Let edit/save the gateway (Done with this patch)
2. Let pay with gateway Boleto (Done with this patch)
3. Let pay with gateway OpenInvoice (Removed for now to complete later)
Advances:
- Code for Bolete payment method completely in plugin
Comment #9
vacho commentedUpdating the progress in this patch
1. Let edit/save the gateway (Done with this patch)
2. Let pay with gateway Boleto (Done with this patch)
3. Let pay with gateway OpenInvoice (Done with this patch)
Todo:
Review, test this patch and refactor or enhance it.
Comment #10
vacho commentedAdvances:
- Add composer dependencies
- Refactor Adyen internal module api (this api interact with Adyen php library)
- Advance in complete parameters for Adyen interna module API.
Comment #11
julien commentedThanks @vacho for your work.
I tested patch #5 who apply properly against the 8.x branch. Will commit it soon after testing other patches. I have the last one with some errors while applying.
Comment #13
julien commented@vacho commited the only patch that apply against HEAD of 8.x branch.
Can you repost the latest patch from latest 8.X commit ?
Comment #14
vacho commentedHi.
About patchs 5,7,8,9,10 I had created it all on the branch 8.x-1.x each and they have radical changes one from the other. That's why they do not apply one over the other. (This patches are independent advances)
Now I update in my local the branch 8.x-1.x and apply over it the last changes that I work. This last patch should be applied over current 8.x-1.x directly
NOTE: this last patch contains radical changes in module:
In internal module Adyen API:
- Remove some that D7 functions (All those involved in the request for payment methods)
- Move to inside src/ for use namespaces (D8 way)
In module:
- Change internal modules logic for Plugins logic for off-site gateways (commerce 2 way)
Comment #16
julien commentedComment #17
julien commentedComment #18
sophie.skHello, thank you for the work on this module :)
As this has been committed to the branch should the status be "fixed"?
Is it possible to do a 1.0-rc1 release with this code? We are looking internally to possibly use this module and would be happy to contribute to the queue going forward, but it would give our stakeholders greater confidence if the module had a release, not just a dev version.
Is there anything else that the module needs in order to achieve this?
Thank you!
Comment #19
julien commentedHi Sophie,
Yes i will do one release when i get back to my place in a couple of hours. I'm blocked by the office proxy to use git ssh
Comment #20
sophie.skTypical technology, blocking us from doing what we need to do :-)
Thank you - I appreciate that you're doing that so quickly!
Comment #21
julien commentedi made the release Sophie. https://www.drupal.org/project/commerce_adyen/releases/8.x-1.0-alpha1
Please create new tickets if you wish to contribute, i will close this one i guess. Thanks to @vacho
Comment #22
julien commentedComment #23
sophie.skThanks again both! Much appreciated!