Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ckrina created an issue. See original summary.

ckrina’s picture

- It is not vegan but it is vegetarian (it doesn't have meat). I'm not sure if we are using the term vegetarian for dishes with egg&milk.
- I think it's known by crema catalana everywhere, but it could be changed to Crema Catalana (catalan cream).
- Not sure about the capitals. Should they be lowercase.
- It needs a revision from a good/native English speaker :)
- Not sure how to abbreviate liter to follow the standards from #2940146: Standardize writing style for Umami in English.

Eli-T’s picture

It is not vegan but it is vegetarian (it doesn't have meat). I'm not sure if we are using the term vegetarian for dishes with egg&milk.

Vegetarian is correct for dishes with egg and milk.

I think it's known by crema catalana everywhere, but it could be changed to Crema Catalana (catalan cream).

Not sure about the capitals. Should they be lowercase

I'm not sure here - Wikipedia goes with Crema catalana,

It needs a revision from a good/native English speaker :)

Will try :)

Not sure how to abbreviate liter

l should be fine, as we use ml for milliliter

Image file and crema-catalana-umami.html need adding to the patch.

Reviewing the text from the image as the html file isn't available, so can't test installing.

Ingredients

  1. 1 liter of milk -> 1l milk
  2. 200g of sugar -> 200g sugar
  3. 30g of refined cornmeal -> 30g refined cornmeal (although I'm not sure what this is, or if it's called by a different name especially in the US)
  4. 1 cinnamon crust -> 1 cinnamon stick
  5. 1 piece of lemon peel -> 1 piece lemon peel

Instructions

  1. Dilute the egg yolks -> dilute isn't really the right word here. Maybe just instruct to mix all the things together?
  2. In a saucepan... -> In a saucepan, boil 2/3 of the milk with the lemon peel and cinnamon.
  3. Slowly, .... -> Slowly pass the egg mixture through a strainer to ensure there are no lumps.
  4. Add it again to heat -> Add it to the heat again
  5. ...and put it in the bowls to let it cool down -> and put it in bowls to cool.

I wasn't sure shovel was the right word here - I was expecting a blowtorch, but having read a few recipes it seems a heated iron is used?

Also I'm not sure at what point the two mixtures are put together - is it that in step 4 that you are passing the egg mixture through the strainer in to the milk? Maybe we could be more explicit about that. Also I'm not sure if strainer or sieve would be the more common word in the US. In the UK I think most people would say sieve.

andrewmacpherson’s picture

Refined cornmeal - this'll be what we call cornflour in the UK. A fine white powder used for thickening, yes? A bit of googling tells me the Americans call it cornstarch.

(It's also the main thing in good old Birds Custard Powder, but that has yellow colourings too.)

andrewmacpherson’s picture

Boom. A tin of Bird's custard powder actually says "cornflour (aka cornstarch)" on the ingredients.

http://www.cooksinfo.com/custard-powder

I make bloomin' great custard. No lumps.

ckrina’s picture

@Eli-T thanks!! I've just updated the instructions a little bit with your suggestions.

@andrewmacpherson you're right, thanks for that!

Here's a new patch, this time with the image...

ckrina’s picture

Status: Active » Needs review
Issue tags: +dcruhr18

The last submitted patch, 2: add_crema_catalana-2952059-2.patch, failed testing. View results

Eli-T’s picture

Status: Needs review » Needs work

Applied the patch and installed. Recipe is added on install. Much closer now!

Some suggestions:

Recipe category, summary and alt text should refer to dessert, not desert.

The alt text on the main image is

Typical Catalan desert made from pastry cream based on egg yolk that is usually covered with a layer of caramelized sugar to provide a crispy contrast.

I can't see any reference to pastry in the recipe. Also the alt text as far as I'm aware should describe what's in the picture, not how it is usually made. So maybe something like

Typical Catalan dessert made from cream and egg yolks, covered with a traditional layer of caramelized sugar to provide a crispy contrast.

We probably want to swap the following in the summary:

Enjoy this sweet recipe of one of the oldest deserts in Europe. It requires very few ingredients!

to

Enjoy this sweet recipe for one of the oldest desserts in Europe. It requires very few ingredients!

Maybe if we're going to keep the word shovel at the end of the instructions we should mention is should be hot? I'm still not sure about using the word shovel here.

Also I could not get the image to display - I initially thought this was down to my environment, but I can't get it to open in MacOS Preview app either.

ckrina’s picture

Issue tags: +Novice
ckrina’s picture

FileSize
60.85 KB

Uploading the photo in case anyone wants to fix this issue during the sprint.

Ada Hernandez’s picture

suggestions added from #9

BrightBold’s picture

Assigned: Unassigned » BrightBold
BrightBold’s picture

Assigned: BrightBold » Unassigned
Status: Needs review » Needs work
FileSize
117.01 KB
4.47 KB

I made the following changes. Still needs review and @ckrina please make sure I didn't do anything that changes the intent of your original recipe. I wanted to provide some native English speaker review but I don't want to overstep!

  1. Changed "Desert" to "Dessert" in the recipe category.
  2. Added a serial comma in the first step of the instructions per Umami standards.
  3. Changed "cornmeal" to "cornstarch" in step 1.
  4. In step 4, to remove a duplicate reference to the egg mixture, I changed "Slowly add to the hot milk the egg mixture of the eggs" to "Slowly add the egg mixture to the hot milk."
  5. Reworded step 6 a little to provide a little more clarity on next steps. If I overstepped in my editing it was here so please review, @ckrina! I changed "When it boils, remove from the heat and put it in bowls to cool." to "Once the mixture has begun to thicken, remove from the heat and put it into individual bowls to cool."
  6. In step 7, changed "shovel" to "blowtorch" but also added the option to do it under a broiler since most people don't have a kitchen blowtorch. I also changed "burn" to "caramelize."

Things that I did not know how to fix:

  • The image creates a trailing whitespace error in the patch. I'm not sure if this is a problem we actually need to worry about but if so it still needs fixing.
  • Even though the image is in the default_content/images folder, it's not loading on the page, but I'm not clear as to why.
BrightBold’s picture

Status: Needs work » Needs review
FileSize
65.74 KB

Fixed the image (at least on my local) by just deleting and re-adding it. It still throws whitespace errors but I'm thinking this is in the image so it's not actually a problem.

timwood’s picture

Hi BrightBold, I'm going to review the latest patch at DrupalCon Nashville.

timwood’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +Nashville2018
FileSize
2.15 MB

When applying the patch locally, I also noticed the trailing whitespace warning, but it's just a warning and I also believe this is due to the image binary. Git apply can be configured to fail or warn and when using the patch command doesn't even display the warning.

After a fresh Drupal install I see the Crema catalana recipe with the recipe category, tags, image, ingredients, instructions, etc. (screen attached). Looks awesome and yummy! I'm going to try and make this recipe when I get home from Nashville!

benjifisher’s picture

I checked, and the only trailing whitespace is in the JPEG file. Trailing whitespace in a text file violates Drupal's coding standards, but there is nothing we can do about binaries.

  • lauriii committed 1454853 on 8.6.x
    Issue #2952059 by ckrina, BrightBold, Adita, timwood, Eli-T: Add Crema...

  • lauriii committed 5cb8838 on 8.5.x
    Issue #2952059 by ckrina, BrightBold, Adita, timwood, Eli-T: Add Crema...
lauriii’s picture

Status: Reviewed & tested by the community » Fixed

Committed 1454853 and pushed to 8.6.x. I also cherry-picked this to 8.5.x as this only affects experimental code. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.