Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This patch adds a new recipe to the default content created on the Umami profile.
Comment | File | Size | Author |
---|---|---|---|
#17 | screencapture-sprint-20180413-1048-ddev-local-8443-recipes-crema-catalana-2018-04-13-14_12_43.png | 2.15 MB | timwood |
#15 | add_crema_catalana-2952059-15.patch | 65.74 KB | BrightBold |
#14 | interdiff-12-14.txt | 4.47 KB | BrightBold |
#14 | add_crema_catalana-2952059-14.patch | 117.01 KB | BrightBold |
#12 | interdiff-6-12.txt | 2.88 KB | Ada Hernandez |
Comments
Comment #2
ckrina- It is not vegan but it is vegetarian (it doesn't have meat). I'm not sure if we are using the term vegetarian for dishes with egg&milk.
- I think it's known by crema catalana everywhere, but it could be changed to Crema Catalana (catalan cream).
- Not sure about the capitals. Should they be lowercase.
- It needs a revision from a good/native English speaker :)
- Not sure how to abbreviate liter to follow the standards from #2940146: Standardize writing style for Umami in English.
Comment #3
Eli-TVegetarian is correct for dishes with egg and milk.
I'm not sure here - Wikipedia goes with Crema catalana,
Will try :)
l should be fine, as we use ml for milliliter
Image file and crema-catalana-umami.html need adding to the patch.
Reviewing the text from the image as the html file isn't available, so can't test installing.
Ingredients
Instructions
I wasn't sure shovel was the right word here - I was expecting a blowtorch, but having read a few recipes it seems a heated iron is used?
Also I'm not sure at what point the two mixtures are put together - is it that in step 4 that you are passing the egg mixture through the strainer in to the milk? Maybe we could be more explicit about that. Also I'm not sure if strainer or sieve would be the more common word in the US. In the UK I think most people would say sieve.
Comment #4
andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer and at Annertech commentedRefined cornmeal - this'll be what we call cornflour in the UK. A fine white powder used for thickening, yes? A bit of googling tells me the Americans call it cornstarch.
(It's also the main thing in good old Birds Custard Powder, but that has yellow colourings too.)
Comment #5
andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer and at Annertech commentedBoom. A tin of Bird's custard powder actually says "cornflour (aka cornstarch)" on the ingredients.
http://www.cooksinfo.com/custard-powder
I make bloomin' great custard. No lumps.
Comment #6
ckrina@Eli-T thanks!! I've just updated the instructions a little bit with your suggestions.
@andrewmacpherson you're right, thanks for that!
Here's a new patch, this time with the image...
Comment #7
ckrinaComment #9
Eli-TApplied the patch and installed. Recipe is added on install. Much closer now!
Some suggestions:
Recipe category, summary and alt text should refer to dessert, not desert.
The alt text on the main image is
I can't see any reference to pastry in the recipe. Also the alt text as far as I'm aware should describe what's in the picture, not how it is usually made. So maybe something like
We probably want to swap the following in the summary:
to
Maybe if we're going to keep the word shovel at the end of the instructions we should mention is should be hot? I'm still not sure about using the word shovel here.
Also I could not get the image to display - I initially thought this was down to my environment, but I can't get it to open in MacOS Preview app either.
Comment #10
ckrinaComment #11
ckrinaUploading the photo in case anyone wants to fix this issue during the sprint.
Comment #12
Ada Hernandez CreditAttribution: Ada Hernandez at MTech, LLC commentedsuggestions added from #9
Comment #13
BrightBoldComment #14
BrightBoldI made the following changes. Still needs review and @ckrina please make sure I didn't do anything that changes the intent of your original recipe. I wanted to provide some native English speaker review but I don't want to overstep!
Things that I did not know how to fix:
Comment #15
BrightBoldFixed the image (at least on my local) by just deleting and re-adding it. It still throws whitespace errors but I'm thinking this is in the image so it's not actually a problem.
Comment #16
timwoodHi BrightBold, I'm going to review the latest patch at DrupalCon Nashville.
Comment #17
timwoodWhen applying the patch locally, I also noticed the trailing whitespace warning, but it's just a warning and I also believe this is due to the image binary. Git apply can be configured to fail or warn and when using the patch command doesn't even display the warning.
After a fresh Drupal install I see the Crema catalana recipe with the recipe category, tags, image, ingredients, instructions, etc. (screen attached). Looks awesome and yummy! I'm going to try and make this recipe when I get home from Nashville!
Comment #18
benjifisherI checked, and the only trailing whitespace is in the JPEG file. Trailing whitespace in a text file violates Drupal's coding standards, but there is nothing we can do about binaries.
Comment #21
lauriiiCommitted 1454853 and pushed to 8.6.x. I also cherry-picked this to 8.5.x as this only affects experimental code. Thanks!