Fixed coding standards

CommentFileSizeAuthor
#7 2950876-7.patch47.33 KBgnuget
#3 comment_notify-2950876-2.patch42.31 KBdrupalgin
#2 moderation_sidebar-2950875-2.patch16.83 KBdrupalgin
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

drupalgin created an issue. See original summary.

drupalgin’s picture

drupalgin CreditAttribution: drupalgin as a volunteer commented
Status: Active » Needs review
FileSize
moderation_sidebar-2950875-2.patch16.83 KB
drupalgin’s picture

drupalgin CreditAttribution: drupalgin as a volunteer commented
FileSize
comment_notify-2950876-2.patch42.31 KB

The last submitted patch, 2: moderation_sidebar-2950875-2.patch, failed testing. View results

nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
CreditAttribution: nkoporec as a volunteer and commented
Status: Needs review » Reviewed & tested by the community

Tested the patch and it looks good.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles at Morris Animal Foundation commented
Status: Reviewed & tested by the community » Needs work

I committed a few other features and bugfixes first - those seemed harder to me to reroll than this one. Any chance you could go through and provide a new patch?

gnuget’s picture

gnuget
Primary language Spanish
CreditAttribution: gnuget as a volunteer and at Agaric commented
FileSize
2950876-7.patch47.33 KB

Ok, I just left PHPCS and PHPCBF take care of the majority of the issues.

The rest were fixes in the comments.

gnuget’s picture

gnuget
Primary language Spanish
CreditAttribution: gnuget as a volunteer and at Agaric commented
Status: Needs work » Needs review

  • gnuget committed 0546cd5 on 8.x-1.x 
    Issue #2950876 by drupalgin, gnuget: Fixed coding standards
gnuget’s picture

gnuget
Primary language Spanish
CreditAttribution: gnuget as a volunteer and at Agaric commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.