Problem/Motivation

In #2666392: Unable to revert third party settings via config import it was suggested that we deprecate the fallback to schema for discovering a config entities properties to export. And enforce config entities to declare their properties in their annotation config_export property.

Proposed resolution

Add a deprecation and CR so people can prepare for Drupal 9.

Remaining tasks

User interface changes

None

API changes

None - a code path will be deprecate in Drupal 8 and removed in Drupal 9 - so the API change is in Drupal 9.

Data model changes

None

CommentFileSizeAuthor
#11 2949021-configexport-11-interdiff.txt2.2 KBtim.plunkett
#11 2949021-configexport-11.patch7.87 KBtim.plunkett
#7 2949021-configexport-7-interdiff.txt3.58 KBtim.plunkett
#7 2949021-configexport-7.patch7.87 KBtim.plunkett
#5 2949021-config_export-5.patch6.59 KBtim.plunkett
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Issue tags: +Drupal 9
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Priority: Normal » Major
Issue tags: +API-First Initiative
Related issues: +#3015759: `?filter[drupal_internal__id]=ID` does not work: drupal_internal__id should not be converted to uuid when filtering

#3015759-24: `?filter[drupal_internal__id]=ID` does not work: drupal_internal__id should not be converted to uuid when filtering was adversely affected by this not yet having happened: it now needs to have an instance in hand to determine what the schema is of a config entity. So not doing this adversely affects API-First Drupal. Hence increasing priority.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett at Acquia commented
Status: Postponed » Needs review
FileSize
2949021-config_export-5.patch6.59 KB

Not sure why this was postponed, but here's a patch.

Status: Needs review » Needs work

The last submitted patch, 5: 2949021-config_export-5.patch, failed testing. View results

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett at Acquia commented
Status: Needs work » Needs review
FileSize
2949021-configexport-7.patch7.87 KB
2949021-configexport-7-interdiff.txt3.58 KB

Made the trigger_error more helpful and fixed two more config entities.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Needs review » Reviewed & tested by the community

Thanks! This looks great. It adds a deprecation error, has an explicit test for that deprecation error, and fixes all config entity types in core to ensure they don't trigger this deprecation error. Looks ready 👍

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented

Updated the existing change record https://www.drupal.org/node/2949023 to link to this issue.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett at Acquia commented
Status: Reviewed & tested by the community » Needs work

Except the deprecation error has to point to the CR

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett at Acquia commented
Status: Needs work » Reviewed & tested by the community
FileSize
2949021-configexport-11.patch7.87 KB
2949021-configexport-11-interdiff.txt2.2 KB
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Thunder commented
Status: Reviewed & tested by the community » Fixed

Crediting @Wim Leers for digging out the CR

Committed 2bbbaa3 and pushed to 8.7.x. Thanks!

  • alexpott committed 2bbbaa3 on 8.7.x 
    Issue #2949021 by tim.plunkett, Wim Leers: Deprecate schema fallback in...
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented

#10: d'oh, of course!

#12: 🙏😊

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.