I think we need small, frequent disruptive patches as appropriate when we want to stop supporting legacy browsers.

at the moment we build for IE9 and above.

Previously we have limited support to IE11 and above our transpiling build environment should reflect that.

https://www.drupal.org/docs/8/system-requirements/browser-requirements

When I run yarn run build:js ... nothing changes .. but I want the build environment to reflect established policy... because one day it will have consequences.

CommentFileSizeAuthor
#2 targets-2948874-2.patch376 bytesmartin107
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

martin107 created an issue. See original summary.

martin107’s picture

martin107 CreditAttribution: martin107 as a volunteer commented
Assigned: martin107 » Unassigned
Status: Active » Needs review
Issue tags: +Quickfix
FileSize
targets-2948874-2.patch376 bytes

Here is the trivial one line patch

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented
Status: Needs review » Reviewed & tested by the community

I agree that it's a good idea. I tested this, and it is correct that nothing changes in the output of the javascript files.

GrandmaGlassesRopeMan’s picture

GrandmaGlassesRopeMan
he/him
Primary language English
Location 🌎
CreditAttribution: GrandmaGlassesRopeMan at Acquia commented

+1 on this 🎉

justafish’s picture

justafish
she/her
Primary language English
Location London, UK
CreditAttribution: justafish as a volunteer commented

+1 ⬅️✌️➡️

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 567a4c117e to 8.6.x and 9af726b7b1 to 8.5.x. Thanks!

Backported to 8.5.x since E11 has been the target for a while.

  • alexpott committed 567a4c1 on 8.6.x 
    Issue #2948874 by martin107: Restrict build targets to IE11 and above

  • alexpott committed 9af726b on 8.5.x 
    Issue #2948874 by martin107: Restrict build targets to IE11 and above

(...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.