Split module into admin include and demo_reset module [#294879]

Demo is widely used as developer tool only. So all demonstration site features should go into a sub-module demo_reset, to avoid Demo's blocks from showing up in the block configuration and also save some cycles.

Additionally, Demo should leverage new file handler attributes in D6, so all administrative forms and features go into a demo.admin.inc. For D5, this should use a helper function in demo.module that includes admin.inc and invokes the corresponding function, so the differences between D5 and D6 are kept at a minimum.

Comment	File	Size	Author
#1	demo-split.patch	37.87 KB	smk-ka

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

smk-ka CreditAttribution: smk-ka commented 28 October 2008 at 18:35

File	Size
demo-split.patch	37.87 KB

Split module for 6.x branch.

Comment #2

smk-ka CreditAttribution: smk-ka commented 28 October 2008 at 19:08

Status:

Active

» Fixed

Committed to all branches.
http://drupal.org/cvs?commit=149505

Comment #3

smk-ka CreditAttribution: smk-ka commented 28 October 2008 at 19:12

Note: With demo.module now weighting at ~4KB I don't believe it would make sense to further split the module apart. Feel free to open a new issue if you disagree. :)

Comment #4

sun

German

Karlsruhe

CreditAttribution: sun commented 28 October 2008 at 20:43

Status:

Fixed

» Active

Cool. 8)

However, the point of this issue was that when Demo module is used on regular sites where maybe novice users are allowed to configure blocks, users can easily wreck their sites by (mistakenly) publishing the Demo Reset block and wait for the next visitor... ;)

Comment #5

smk-ka CreditAttribution: smk-ka commented 28 October 2008 at 21:38

Wouldn't a permission make more sense in this case? Something like 'reset site', and then just add $form['#access'] = user_access('reset site')?

Comment #6

sun

German

Karlsruhe

CreditAttribution: sun commented 30 October 2008 at 09:47

AFAIK, a permission would lead to the block not being displayed on admin/build/block if a user has not sufficient permissions. If that user submits the form, all blocks are rehashed, and if the block was enabled (for any reason / special visibility configuration), it would be disabled afterwards.

This will also allow us to maybe place the new links discussed in #294837: Make snapshot now (quick menu item without any kind of confirmation) in demo_reset module, if that makes sense (to be discussed over there).