Problem/Motivation

We had two bugs in a project, a fatal error on a behavior because \Drupal\paragraphs\ParagraphsBehaviorBase::getFieldNameOptions() returned a base field and the summary showing the username despite that being a base field.

After a bit of debugging, the problem turned out to be that the uid field had a base field override. Combined with the problem that we checked the wrong FieldConfigInterface (the one in Drupal\Core covers both configurable fields and base field overrides) and in the other case checked for BaseFieldDefinition which was then not true anymore.

Proposed resolution

Use Drupal\field\FieldInterface in both cases.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#10 interdiff-2946102-7-10.txt1.47 KBjohnchque
#10 paragraphs-fieldconfiginterface-2946102-10.patch3.86 KBjohnchque
#10 paragraphs-fieldconfiginterface-2946102-10-test-only.patch1.81 KBjohnchque
#7 interdiff-2946102-4-7.txt1.18 KBjohnchque
#7 paragraphs-fieldconfiginterface-2946102-7.patch4.8 KBjohnchque
#7 paragraphs-fieldconfiginterface-2946102-7-test-only.patch2.74 KBjohnchque
#4 interdiff-2946102-2-4.txt2.33 KBjohnchque
#4 paragraphs-fieldconfiginterface-2946102-4.patch4.73 KBjohnchque
#4 paragraphs-fieldconfiginterface-2946102-4-test-only.patch2.67 KBjohnchque
#2 paragraphs-fieldconfiginterface-2946102-2.patch2.05 KBBerdir
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir created an issue. See original summary.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Active » Needs review
FileSize
paragraphs-fieldconfiginterface-2946102-2.patch2.05 KB
johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
CreditAttribution: johnchque at MD Systems GmbH commented
Assigned: Unassigned » johnchque

Will add tests for this.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
CreditAttribution: johnchque at MD Systems GmbH commented
FileSize
paragraphs-fieldconfiginterface-2946102-4-test-only.patch2.67 KB
paragraphs-fieldconfiginterface-2946102-4.patch4.73 KB
interdiff-2946102-2-4.txt2.33 KB

Adding tests. :)

The last submitted patch, 4: paragraphs-fieldconfiginterface-2946102-4-test-only.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Status: Needs review » Needs work

The last submitted patch, 4: paragraphs-fieldconfiginterface-2946102-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
CreditAttribution: johnchque at MD Systems GmbH commented
Status: Needs work » Needs review
FileSize
paragraphs-fieldconfiginterface-2946102-7-test-only.patch2.74 KB
paragraphs-fieldconfiginterface-2946102-7.patch4.8 KB
interdiff-2946102-4-7.txt1.18 KB

Maybe now.

The last submitted patch, 7: paragraphs-fieldconfiginterface-2946102-7-test-only.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Needs work 
+++ b/tests/modules/paragraphs_test/src/Plugin/paragraphs/Behavior/TestFieldsSelectionBehavior.php
@@ -22,6 +22,12 @@ class TestFieldsSelectionBehavior extends ParagraphsBehaviorBase {
    */
   public function buildConfigurationForm(array $form, FormStateInterface $form_state) {
+    if ($form_state->getFormObject()->getEntity()->id()) {
+      $paragraphs_type = $form_state->getFormObject()->getEntity();
+      $field_definition = \Drupal::service('entity_field.manager')->getFieldDefinitions('paragraph', $paragraphs_type->id())['uid'];
+      $field_definition->getConfig($paragraphs_type->id())->save();
+    }

You should do this in the test class, not in the test plugin.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
CreditAttribution: johnchque at MD Systems GmbH commented
Status: Needs work » Needs review
FileSize
paragraphs-fieldconfiginterface-2946102-10-test-only.patch1.81 KB
paragraphs-fieldconfiginterface-2946102-10.patch3.86 KB
interdiff-2946102-7-10.txt1.47 KB

Indeed, my bad.

The last submitted patch, 10: paragraphs-fieldconfiginterface-2946102-10-test-only.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

The last submitted patch, 10: paragraphs-fieldconfiginterface-2946102-10-test-only.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Reviewed & tested by the community

Looks good I think.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker at MD Systems GmbH commented
Status: Reviewed & tested by the community » Fixed

:-) Committed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.