Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
In #2927746: Update Symfony components to 3.4.* we had to add a hack to fix yaml before parsing because our default.services.yml had the following structure:
factory.keyvalue:
{}
# Default key/value storage service to use.
# @default keyvalue.database
# default: keyvalue.database
# Collection-specific overrides.
# state: keyvalue.database
factory.keyvalue.expirable:
{}
# Default key/value expirable storage service to use.
# @default keyvalue.database.expirable
# default: keyvalue.database.expirable
# Allowed protocols for URL generation.
Proposed resolution
Remove the hack and update to the dev version of symfony/yaml 3.4 which contains https://github.com/symfony/symfony/pull/25787 - hopefully symfony will do a bugfix release before 8.5.0 but it is better to be on the dev release than have a preg_replace()
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#7 | 2945275-7.patch | 4.6 KB | alexpott |
#7 | 5-7-interdiff.txt | 458 bytes | alexpott |
#5 | 2945275-5.patch | 4.15 KB | alexpott |
#5 | 2-5-interdiff.txt | 1.04 KB | alexpott |
#2 | 2945275-2.patch | 4.81 KB | alexpott |
Comments
Comment #2
alexpottComment #3
alexpottI asked @nicolasgrekas of Symfony when the next bugfix release for Symfony 3.4 is going to be. His reply was that it would be end of this month or very early next month. So there is a good chance that 3.4.5 will be released before Drupal 8.5.0 but it will be cutting it very fine.
Comment #4
alexpottThe difference between 3.4.4 and 3.4.x-dev version the patch gets is:
So there are only 2 bugs fixes different - the one we need and a fix for https://github.com/symfony/symfony/issues/26065
Comment #5
alexpottWe've now got a proper release 3.4.5 - so we can update to that. It only includes the same two bug fixes as detailed in #4.
Comment #6
alexpottThe other option here is to update all the components. This is the minimal fix - updating all the components is done in #2949225: Update Symfony components to 3.4.5
Comment #7
alexpottHmmm... also need to update the constraint we are not compatible with anything lower than Symfony\Yaml 3.4.5
Comment #8
alexpottDiscussed with @larowlan, @effulgentsia, @plach, @yoroy, @gabor.hojtsy, @webchick we agreed that this minimal fix should be targeted for 8.5.0 and we'll leave #2949225: Update Symfony components to 3.4.5 till 8.5.1 or later.
Comment #9
larowlanComment #12
catchCommitted/pushed to 8.6.x and cherry-picked to 8.5.x. Thanks!