Problem/Motivation

This is a follow-up to #2801817: Inject services into SimpletestTestForm and functional cleanup for the test_discovery service which deprecated these simpletest module functions:

  • simpletest_test_get_all()
  • simpletest_classloader_register()

That issue marked these functions as deprecated and removed their usages in simpletest's UI form.

This issue removes the remaining usages from run-tests.sh.

Proposed resolution

Replace usages in run-tests.sh with replacements, based on the test_discovery service provided by the simpletest module.

Trigger deprecation errors from these functions.

Add a test to prove the deprecation errors work.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 2945247_2.patch4.69 KBMile23
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Mile23 created an issue. See original summary.

Mile23’s picture

Added @trigger_error() in places, added a test that proves the deprecations work, and changes the usages of the deprecated functions in run-tests.sh.

Mile23’s picture

Mile23’s picture

Issue tags: +@deprecated
borisson_’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me, nice to see that tests are added for this.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 42e7150 and pushed to 8.6.x. Thanks!

  • alexpott committed 42e7150 on 8.6.x
    Issue #2945247 by Mile23: Remove usages of @deprecated simpletest...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.