Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
In the original design for the Umami theme, on the Recipes pages (/recipes
) there was a block or region where a list of collections of recipes could be found.
Proposed resolution
Create this region with some list of collections. It could be useful to showcase:
- Block capacity to be added to some paths, if it's a block
- Tag & classify content
- Something else?
It could be potentially related to #2943353: Umami Theme - Quick links block homepage depending on the approach taken there.
Remaining tasks
- Decide the approach to take
- Create or modify the content
- Add styles
User interface changes
Comment | File | Size | Author |
---|---|---|---|
#23 | interdiff.txt | 652 bytes | lauriii |
#20 | recipe_collections_2943661_15.patch | 9.2 KB | lauriii |
#18 | interdiff_recipe_collections_2943661_18.txt | 14.67 KB | dean-coakley |
#12 | recipe_collections_2943661_12.patch | 10.01 KB | BrightBold |
#10 | recipe_collections_2943661_10.patch | 9.98 KB | dslobodyanik |
Comments
Comment #2
ckrinaComment #3
cilefen CreditAttribution: cilefen at Institute for Advanced Study commentedComment #4
Eli-TApologies if I'm stating the obvious but it seems like we're going to need a lot more than 7 recipes to be able to build decent recipe collections. Should we defer this until we know how many we're likely to amass?
Comment #5
ckrinaAs we said in the weekly call, we can mark each issue with several tags (vegan, healthy, Catalan) so we could have enough content. Anyway, the theming and development could be done with fake content until we have more recipes.
Comment #6
Eli-TLinking #2940146: Standardize writing style for Umami in English so if we add tags in this issue we can double check we don't remove them in that one.
Comment #7
markconroy CreditAttribution: markconroy as a volunteer and at Annertech commentedComment #8
ckrinaComment #9
dslobodyanik CreditAttribution: dslobodyanik commentedIt seems like we do have some tags for recipes. The next step would probably be to add view to display the tags as in the design then? I can get a start on that.
Comment #10
dslobodyanik CreditAttribution: dslobodyanik commentedHere's a patch that includes the config and theming for the block. I added a new region since the block needed to be full width.
Comment #11
ckrinaComment #12
BrightBoldThe patch in #10 was missing
a/
andb/
beforecore/profiles/demo_umami...
so did not apply. This one contains no changes other than fixing those paths.Comment #14
markconroy CreditAttribution: markconroy as a volunteer and at Annertech commentedHi Folks,
This patch looks really good. Thanks so much for working on it. A few (tiny) issues:
From this:
To this:
Comment #15
dean-coakley CreditAttribution: dean-coakley as a volunteer commentedHi All,
Found this issue via @markconroy and thought I'd give it a shot.
I hope I went through the correct process
EDIT: Accidental issue summary deletion?
https://www.drupal.org/node/2943661/revisions/view/11073840/11075510
Comment #16
Eli-THi @dean-coakley!
Could you supply an interdiff to the previous patch please? https://www.drupal.org/documentation/git/interdiff
Comment #17
Eli-TComment #18
dean-coakley CreditAttribution: dean-coakley as a volunteer commented@Eli-T How's this?
Comment #19
markconroy CreditAttribution: markconroy as a volunteer and at Annertech commentedHi @dean-coakley,
Thanks a lot for that patch. It completes the items I requested and applies cleanly to 8.7.x branch.
I'm going to mark this RTBC (Reviewed and Tested by the Community).
Thanks a lot for getting involved in Drupal Core contribution. Just for future reference, if you complete work based on a patch from someone else, we like to get 2 things:
The interdiff you supplied was just a text file of all the changes, rather than just the differences between your code and the previous patchers.
Again, thanks a lot for helping out. We really appreciate it.
Comment #20
lauriiiRe-uploading the latest patch for CI.
Comment #23
lauriiiThere was a minor stylelint problem which I fixed on commit (interdiff attached).
Committed 74c323f and pushed to 8.7.x. Also cherry-picked f51f707 and pushed to 8.6.x. Thanks! ✨