Problem/Motivation

In the original design for the Umami theme, on the Recipes pages (/recipes) there was a block or region where a list of collections of recipes could be found.

Proposed resolution

Create this region with some list of collections. It could be useful to showcase:

  1. Block capacity to be added to some paths, if it's a block
  2. Tag & classify content
  3. Something else?

It could be potentially related to #2943353: Umami Theme - Quick links block homepage depending on the approach taken there.

Remaining tasks

  • Decide the approach to take
  • Create or modify the content
  • Add styles

User interface changes

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ckrina created an issue. See original summary.

ckrina’s picture

Issue summary: View changes
cilefen’s picture

Title: Create the Recipie Colections element » Create the Recipe Colections element
Eli-T’s picture

Apologies if I'm stating the obvious but it seems like we're going to need a lot more than 7 recipes to be able to build decent recipe collections. Should we defer this until we know how many we're likely to amass?

ckrina’s picture

As we said in the weekly call, we can mark each issue with several tags (vegan, healthy, Catalan) so we could have enough content. Anyway, the theming and development could be done with fake content until we have more recipes.

Eli-T’s picture

Linking #2940146: Standardize writing style for Umami in English so if we add tags in this issue we can double check we don't remove them in that one.

markconroy’s picture

Issue tags: +dclondon
ckrina’s picture

Title: Create the Recipe Colections element » Create the Recipe Collections element
Issue tags: +Nashville2018
dslobodyanik’s picture

It seems like we do have some tags for recipes. The next step would probably be to add view to display the tags as in the design then? I can get a start on that.

dslobodyanik’s picture

Here's a patch that includes the config and theming for the block. I added a new region since the block needed to be full width.

ckrina’s picture

Status: Active » Needs review
BrightBold’s picture

The patch in #10 was missing a/ and b/ before core/profiles/demo_umami... so did not apply. This one contains no changes other than fixing those paths.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

markconroy’s picture

Status: Needs review » Needs work

Hi Folks,

This patch looks really good. Thanks so much for working on it. A few (tiny) issues:

  1. Can we remove the UUID from the
    1. core/profiles/demo_umami/config/install/views.view.recipe_collections.yml and
    2. core/profiles/demo_umami/config/install/block.block.views_block__recipe_collections_block.yml files
  2. Can we set the media query in core/profiles/demo_umami/themes/umami/css/components/blocks/recipe-collections/recipe-collections.css to use `em` instead of `px`, see examples in other CSS files
  3. Also in that file, can we make the following change (just to follow our CSS coding standards):

From this:

.block-views-blockrecipe-collections-block .views-row a {
  color: #fff;
  text-decoration: none;
  font-weight: bold;
}
.block-views-blockrecipe-collections-block .views-row a:focus,
.block-views-blockrecipe-collections-block .views-row a:hover {
  background: transparent;
  text-decoration: underline;
}

To this:

.block-views-blockrecipe-collections-block .views-row a {
  text-decoration: none;
  color: #fff;
  font-weight: bold;
}
.block-views-blockrecipe-collections-block .views-row a:focus,
.block-views-blockrecipe-collections-block .views-row a:hover {
  text-decoration: underline;
  background: transparent;
}
dean-coakley’s picture

Issue summary: View changes
FileSize
9.2 KB

Hi All,

Found this issue via @markconroy and thought I'd give it a shot.

I hope I went through the correct process

git checkout 8.6.x
vim patch.patch
git apply patch.patch
git status
# made requested changes
git add .
git diff --staged > recipe_collections_2943661_15.patch

EDIT: Accidental issue summary deletion?
https://www.drupal.org/node/2943661/revisions/view/11073840/11075510

Eli-T’s picture

Hi @dean-coakley!

Could you supply an interdiff to the previous patch please? https://www.drupal.org/documentation/git/interdiff

Eli-T’s picture

Status: Needs work » Needs review
dean-coakley’s picture

@Eli-T How's this?

markconroy’s picture

Status: Needs review » Reviewed & tested by the community

Hi @dean-coakley,

Thanks a lot for that patch. It completes the items I requested and applies cleanly to 8.7.x branch.

I'm going to mark this RTBC (Reviewed and Tested by the Community).

Thanks a lot for getting involved in Drupal Core contribution. Just for future reference, if you complete work based on a patch from someone else, we like to get 2 things:

  1. A new patch from you with the updated work,
  2. An 'interdiff' between your patch and the patch you worked from which shows us just the lines that have changed from on to the other.

The interdiff you supplied was just a text file of all the changes, rather than just the differences between your code and the previous patchers.

Again, thanks a lot for helping out. We really appreciate it.

lauriii’s picture

Re-uploading the latest patch for CI.

  • lauriii committed 74c323f on 8.7.x
    Issue #2943661 by dslobodyanik, BrightBold, lauriii, ckrina, dean-...

  • lauriii committed f51f707 on 8.6.x
    Issue #2943661 by dslobodyanik, BrightBold, lauriii, ckrina, dean-...
lauriii’s picture

Status: Reviewed & tested by the community » Fixed
FileSize
652 bytes

There was a minor stylelint problem which I fixed on commit (interdiff attached).

Committed 74c323f and pushed to 8.7.x. Also cherry-picked f51f707 and pushed to 8.6.x. Thanks! ✨

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.