Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Moving the addition of Chili Sauce from #2940146: Standardize writing style for Umami in English to a separate issue so that issue can focus purely on standardisation of what we already have.
Comment | File | Size | Author |
---|---|---|---|
#37 | Screen Shot 2018-05-12 at 10.49.53.png | 72.92 KB | Anonymous (not verified) |
#36 | interdiff_2943284_26_36.txt | 1.48 KB | Eli-T |
#36 | 2943284_36_clarify_blending.patch | 103.57 KB | Eli-T |
#27 | Screenshot from 2018-04-27 14-54-11.png | 130.2 KB | Mukeysh |
#26 | fiery-chili-sauce.png | 2.8 MB | kaythay |
Comments
Comment #2
Eli-TComment #4
Eli-TComment #5
kjay CreditAttribution: kjay commentedHere's the image now cropped, tweaked and compressed at 768px wide.
Comment #6
Eli-THere's Keith's awesome optimised image rolled in to the patch.
No interdiff because binary interdiffs = nonsense in the face.
Comment #7
Eli-TPostponing until #2940146: Standardize writing style for Umami in English is committed - we can then review this against the style guidlines agreed in that issue.
Comment #8
Eli-TNeeds work to bring up to the latest standard agreed in #2940146: Standardize writing style for Umami in English - at least having oven temps in F and C and using the degree symbol.
Comment #9
Eli-TStandardised according to #2940146: Standardize writing style for Umami in English rules.
No interdiff as I don't think the previous patch was reviewed.
Comment #10
kjay CreditAttribution: kjay commentedThis patch applies cleanly and looks great. Content looks ready to go.
Marking as Needs work because the only issue I've spotted is that the image should be added to the licence.txt file.
Adding a screenshot so others can review easily.
Comment #11
Eli-TAddressed @kjay comment from #10
Comment #12
ckrinaComment #13
kaythay CreditAttribution: kaythay commentedHi, I'm in the sprint room, and I am going to review this patch.
Comment #14
kaythay CreditAttribution: kaythay commentedI applied the patch pre-install and everything looks good. Attaching images before and after the patch.
Comment #15
alexpott#2952059: Add Crema Catalana to Umami was added.
Comment #16
kaythay CreditAttribution: kaythay commentedRerolled.
Comment #17
mcgovernm CreditAttribution: mcgovernm as a volunteer commentedTested patch being applied after reroll. This looks good to me.
Comment #18
mcgovernm CreditAttribution: mcgovernm as a volunteer commentedMarking as reviewed and tested.
Comment #19
alexpottDiscussed the recipe title a bit with @lauriii and @eli-t (in separate chats). The issue is what does "Mwmbwldraig" mean? It is explained in the text but it does induce a wtf. Also it was pointed out that chillies are not from Wales and none of the other recipes has this type of name. They all are a well recognised name of dish.
Comment #20
kaythay CreditAttribution: kaythay commentedRecommend changing name to "Fiery chili sauce"
Comment #21
kaythay CreditAttribution: kaythay commentedComment #23
kaythay CreditAttribution: kaythay commentedComment #24
Eli-TThanks @kaythay! Love the new name.
I 100% agree with @alexpott in #19.
However I think we haven't addressed the entirety of his point - the description is also problematic.
could be read as saying that chili sauce was invented in Wales, when it totes wasn't.
Maybe something like
instead?
Comment #25
savkaviktor16@gmail.com CreditAttribution: savkaviktor16@gmail.com at Skilld commentedComment #26
kaythay CreditAttribution: kaythay commentedComment #27
Mukeysh CreditAttribution: Mukeysh as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commentedPatch applied successfully with some warnings. Attaching screenshot for refrence.
Comment #28
borisson_The problem mentioned in #27 is only in the image, and we shouldn't worry about that.
I did have some small questions about the text, but I haven't read the writing style issues for umami yet, so feel free to ignore those. They were the only nits I had to pick, otherwise this looks great.
I'm not a native speaker, but this is the first time that I've seen a recipe say to rub with lemon juice. Is sprinkle the same?
I'm not sure about the language here either.
Simmer for at least 10 minutes, breaking up as you go. Once broken up, mix in the sugar.
I would replace that with something like:
Simmer for at least 10 minutes. When the vegetables are broken up, mix in the sugar.
That reads easier for me.
Comment #29
Eli-T@borisson_ thanks for taking a look.
No. Rubbing involves using your hands to mix the ingredients. I'm confident this is the correct term here. http://www.recipetips.com/glossary-term/t--35085/rub.asp
Your suggestion would actually mean something different - it implies that the act of simmering will break down the vegetables. My version is intended to instruct the reader that they themselves must break down the vegetables as they are simmering. For instance using a masher or a hand blender.
Do you think it would be better saying
?
Comment #30
borisson_Yes, that makes it clearer what action is needed, I prefer that.
Comment #31
Eli-TComment #32
Eli-TImplemented suggestion from #29
Comment #34
Eli-TLooks like a testbot blip.Prev patch is 0 bytes. Can't blame the testbot for that.
Comment #35
Eli-TComment #36
Eli-TComment #37
Anonymous (not verified) CreditAttribution: Anonymous as a volunteer commentedPatch applies fine. Applied before install, after install I can see the amended step.
Comment #39
Eli-TPutting back for retest as the fail reported in #38 looks nonsense.
Comment #40
cferthorneyPatch 36 looks good. Tests seem to pass. Waiting for 1 more person to confirm before RTBC.
Comment #41
alexpottThere was a testbot snafu over the weekend.
Comment #42
alexpott@Mukeysh Thank you for reviewing this issue!
The automated testing infrastructure tells us whether the patch applies, so we do not need people to review that. It is also not sufficient criteria for the issue to be marked "Reviewed and Tested by the Community".
What we do need people to review is whether the issue has a correct scope, whether it passes the core gates, whether the solution completely fixes the problem without introducing other problems, and whether it's the best solution we can come up with. See the patch review guide for more information.
When you do post a review, be sure to describe what you reviewed and how. This helps other reviewers understand why you considered the issue RTBC (and is considered for issue credit).
Posting screenshots of your codebase is not helpful, since the automated testing infrastructure tells us whether the patch applies correctly.
So, I've removed your credit for this issue. In the future, you can get credit for issues by reading the issue to understand its purpose, and posting your review or testing of that purpose.
Comment #43
alexpottCommitted and pushed 6d4cd5d404 to 8.6.x and c126800aaa to 8.5.x. Thanks!
Comment #46
Mukeysh CreditAttribution: Mukeysh as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented@alexpott thanks for your suggestions. I will take care of this in future.