Moving the addition of Chili Sauce from #2940146: Standardize writing style for Umami in English to a separate issue so that issue can focus purely on standardisation of what we already have.

CommentFileSizeAuthor
#37 Screen Shot 2018-05-12 at 10.49.53.png72.92 KBAnonymous (not verified)
#36 interdiff_2943284_26_36.txt1.48 KBEli-T
#36 2943284_36_clarify_blending.patch103.57 KBEli-T
#32 interdiff_2943284_26_32.txt102.69 KBEli-T
#32 2943284_32_clarify_blending.patch0 bytesEli-T
#27 Screenshot from 2018-04-27 14-54-11.png130.2 KBMukeysh
#26 fiery-chili-sauce.png2.8 MBkaythay
#26 2943284-3.patch103.53 KBkaythay
#23 2943284-2.patch103.58 KBkaythay
#20 screencapture-fiery.png2.81 MBkaythay
#20 screencapture-recipes-fiery.png8.35 MBkaythay
#20 2943284-rename.patch3.09 KBkaythay
#17 after-patch.png433.47 KBmcgovernm
#17 before-patch.png461.43 KBmcgovernm
#16 2960528-reroll.patch103.52 KBkaythay
#16 umami-reroll.png8.4 MBkaythay
#14 chili-sauce-post-patch.png2.88 MBkaythay
#14 recipes-page-post-patch.png7.95 MBkaythay
#14 recipes-page-prepatch.png7.45 MBkaythay
#11 interdiff_2943284_9_11.txt464 bytesEli-T
#11 2943284_11_add_image_to_LICENCE.patch103.55 KBEli-T
#10 Screenshot-2018-3-9 Mwmbwldraig chili sauce Site-Install.jpg1.52 MBkjay
#9 2943284_9_standardize_text.patch102.92 KBEli-T
#6 2943284_6_add_keiths_optimised_image.patch103.02 KBEli-T
#5 hot-chilli-sauce.jpg98.13 KBkjay
#4 2943284_4_lets_try_that_again.patch203.31 KBEli-T
#2 2943284_2_add_chili_sauce.patch204.79 KBEli-T
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Eli-T created an issue. See original summary.

Eli-T’s picture

Status: Active » Needs review
FileSize
204.79 KB

Status: Needs review » Needs work

The last submitted patch, 2: 2943284_2_add_chili_sauce.patch, failed testing. View results

Eli-T’s picture

Status: Needs work » Needs review
FileSize
203.31 KB
kjay’s picture

FileSize
98.13 KB

Here's the image now cropped, tweaked and compressed at 768px wide.

Eli-T’s picture

Here's Keith's awesome optimised image rolled in to the patch.

No interdiff because binary interdiffs = nonsense in the face.

Eli-T’s picture

Status: Needs review » Postponed

Postponing until #2940146: Standardize writing style for Umami in English is committed - we can then review this against the style guidlines agreed in that issue.

Eli-T’s picture

Status: Postponed » Needs work

Needs work to bring up to the latest standard agreed in #2940146: Standardize writing style for Umami in English - at least having oven temps in F and C and using the degree symbol.

Eli-T’s picture

Status: Needs work » Needs review
FileSize
102.92 KB

Standardised according to #2940146: Standardize writing style for Umami in English rules.

No interdiff as I don't think the previous patch was reviewed.

kjay’s picture

Status: Needs review » Needs work
FileSize
1.52 MB

This patch applies cleanly and looks great. Content looks ready to go.

Marking as Needs work because the only issue I've spotted is that the image should be added to the licence.txt file.

Adding a screenshot so others can review easily.

Eli-T’s picture

Status: Needs work » Needs review
FileSize
103.55 KB
464 bytes

Addressed @kjay comment from #10

ckrina’s picture

Issue tags: +dcruhr18
kaythay’s picture

Issue tags: +Nashville2018

Hi, I'm in the sprint room, and I am going to review this patch.

kaythay’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
7.45 MB
7.95 MB
2.88 MB

I applied the patch pre-install and everything looks good. Attaching images before and after the patch.

alexpott’s picture

Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll
kaythay’s picture

Status: Needs work » Needs review
FileSize
8.4 MB
103.52 KB

Rerolled.

mcgovernm’s picture

Status: Needs review » Reviewed & tested by the community

Marking as reviewed and tested.

alexpott’s picture

Status: Reviewed & tested by the community » Needs work

Discussed the recipe title a bit with @lauriii and @eli-t (in separate chats). The issue is what does "Mwmbwldraig" mean? It is explained in the text but it does induce a wtf. Also it was pointed out that chillies are not from Wales and none of the other recipes has this type of name. They all are a well recognised name of dish.

kaythay’s picture

Recommend changing name to "Fiery chili sauce"

kaythay’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 20: 2943284-rename.patch, failed testing. View results

kaythay’s picture

Status: Needs work » Needs review
FileSize
103.58 KB
Eli-T’s picture

Status: Needs review » Needs work

Thanks @kaythay! Love the new name.

I 100% agree with @alexpott in #19.

However I think we haven't addressed the entirety of his point - the description is also problematic.

A rich and fiery chili sauce, named from the Welsh headland where it was first made

could be read as saying that chili sauce was invented in Wales, when it totes wasn't.

Maybe something like

A rich and fiery chili sauce. Take care when handling chili peppers. And serve sparingly!

instead?

savkaviktor16@gmail.com’s picture

Issue tags: -Needs reroll
kaythay’s picture

Status: Needs work » Needs review
FileSize
103.53 KB
2.8 MB
Mukeysh’s picture

Patch applied successfully with some warnings. Attaching screenshot for refrence.umami

borisson_’s picture

The problem mentioned in #27 is only in the image, and we shouldn't worry about that.

I did have some small questions about the text, but I haven't read the writing style issues for umami yet, so feel free to ignore those. They were the only nits I had to pick, otherwise this looks great.

  1. +++ b/core/profiles/demo_umami/modules/demo_umami_content/default_content/recipe_instructions/chili-sauce-umami.html
    @@ -0,0 +1,14 @@
    +  <li>Meanwhile, chop the bell peppers to 1 inch pieces. Add the bell peppers and tomatoes to a roasting dish, and rub with lemon juice, olive oil and black pepper. Transfer to the oven and roast for 30 minutes.</li>
    

    I'm not a native speaker, but this is the first time that I've seen a recipe say to rub with lemon juice. Is sprinkle the same?

  2. +++ b/core/profiles/demo_umami/modules/demo_umami_content/default_content/recipe_instructions/chili-sauce-umami.html
    @@ -0,0 +1,14 @@
    +  <li>Once the tomatoes and bell peppers have finished roasting, add them to the pan. Simmer for at least 10 minutes, breaking up as you go. Once broken up, mix in the sugar.</li>
    

    I'm not sure about the language here either.

    Simmer for at least 10 minutes, breaking up as you go. Once broken up, mix in the sugar.
    I would replace that with something like:
    Simmer for at least 10 minutes. When the vegetables are broken up, mix in the sugar.

    That reads easier for me.

Eli-T’s picture

@borisson_ thanks for taking a look.

I'm not a native speaker, but this is the first time that I've seen a recipe say to rub with lemon juice. Is sprinkle the same?

No. Rubbing involves using your hands to mix the ingredients. I'm confident this is the correct term here. http://www.recipetips.com/glossary-term/t--35085/rub.asp

Simmer for at least 10 minutes. When the vegetables are broken up, mix in the sugar.

Your suggestion would actually mean something different - it implies that the act of simmering will break down the vegetables. My version is intended to instruct the reader that they themselves must break down the vegetables as they are simmering. For instance using a masher or a hand blender.

Do you think it would be better saying

Once the tomatoes and bell peppers have finished roasting, add them to the pan. Cook for at least 10 minutes, breaking them up with a masher or hand blender as they simmer. Once broken up, mix in the sugar

?

borisson_’s picture

Yes, that makes it clearer what action is needed, I prefer that.

Eli-T’s picture

Status: Needs review » Needs work
Eli-T’s picture

Status: Needs work » Needs review
Issue tags: -dcruhr18, -Nashville2018 +Nwdug_may18
FileSize
0 bytes
102.69 KB

Implemented suggestion from #29

Status: Needs review » Needs work

The last submitted patch, 32: 2943284_32_clarify_blending.patch, failed testing. View results

Eli-T’s picture

Status: Needs work » Needs review

Looks like a testbot blip.

Prev patch is 0 bytes. Can't blame the testbot for that.

Eli-T’s picture

Status: Needs review » Needs work
Eli-T’s picture

Status: Needs work » Needs review
FileSize
103.57 KB
1.48 KB
Anonymous’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
72.92 KB

Patch applies fine. Applied before install, after install I can see the amended step.

Screenshot of amended step 7

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 36: 2943284_36_clarify_blending.patch, failed testing. View results

Eli-T’s picture

Status: Needs work » Needs review

Putting back for retest as the fail reported in #38 looks nonsense.

cferthorney’s picture

Patch 36 looks good. Tests seem to pass. Waiting for 1 more person to confirm before RTBC.

alexpott’s picture

Status: Needs review » Reviewed & tested by the community

There was a testbot snafu over the weekend.

alexpott’s picture

@Mukeysh Thank you for reviewing this issue!

The automated testing infrastructure tells us whether the patch applies, so we do not need people to review that. It is also not sufficient criteria for the issue to be marked "Reviewed and Tested by the Community".

What we do need people to review is whether the issue has a correct scope, whether it passes the core gates, whether the solution completely fixes the problem without introducing other problems, and whether it's the best solution we can come up with. See the patch review guide for more information.

When you do post a review, be sure to describe what you reviewed and how. This helps other reviewers understand why you considered the issue RTBC (and is considered for issue credit).

Posting screenshots of your codebase is not helpful, since the automated testing infrastructure tells us whether the patch applies correctly.

So, I've removed your credit for this issue. In the future, you can get credit for issues by reading the issue to understand its purpose, and posting your review or testing of that purpose.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed 6d4cd5d404 to 8.6.x and c126800aaa to 8.5.x. Thanks!

  • alexpott committed 6d4cd5d on 8.6.x
    Issue #2943284 by Eli-T, kaythay, kjay, mcgovernm, sjhuda, borisson_:...

  • alexpott committed c126800 on 8.5.x
    Issue #2943284 by Eli-T, kaythay, kjay, mcgovernm, sjhuda, borisson_:...
Mukeysh’s picture

@alexpott thanks for your suggestions. I will take care of this in future.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.