Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Add an availability to add plugins to sources as per:
https://www.drupal.org/project/feeds_tamper/issues/2937728#comment-12434039
Route: admin/structure/feeds/%feed_type/tamper/add/%source
UI: the same or similar to D7
Comment | File | Size | Author |
---|---|---|---|
#10 | interdiff-2942629-5-8.txt | 4.25 KB | MegaChriz |
#5 | feeds_tamper-add_edit_tamper_forms-2942629-5.patch | 26.95 KB | max-kuzomko |
| |||
feeds_tamper_add_plugin_d7_UI.png | 90.66 KB | max-kuzomko |
Comments
Comment #2
max-kuzomko CreditAttribution: max-kuzomko at Smartweb for Fibonacci Web Studio commentedComment #3
max-kuzomko CreditAttribution: max-kuzomko at Smartweb for Fibonacci Web Studio commentedI have rerolled this patch:
Thank you very much @ericgsmith for your help!
Please find attached the patch.
Comment #4
MegaChriz CreditAttribution: MegaChriz as a volunteer commentedGood work. I was able to add and edit Tamper plugins for a feed type (as superuser).
A partial review:
I tested with an user that didn't have the administer feeds_tamper permission, but did have 'Tamper My importer feed type' and got an access denied. So the custom access check should check if the user has one of both permissions. Now both are required.
Minor: there should be a test for this newly added method in FeedTypeTamperMetaTest.
I like it that individual parts of the D7 code are removed. This way we can see better what would be left to port later on.
Comment #5
max-kuzomko CreditAttribution: max-kuzomko at Smartweb for Fibonacci Web Studio commentedHi @MegaChriz,
Thanks for the review!
I have fixed 1, 2, 4.
But faced with some issues with the point 3.
Once it is fixed - I will updated the patch.
Comment #6
max-kuzomko CreditAttribution: max-kuzomko at Smartweb for Fibonacci Web Studio commentedAs discussed let's postpone description.
Comment #7
MegaChriz CreditAttribution: MegaChriz as a volunteer commented@max
I've made start with writing up a review (found only tiny things so far) but wasn't able to finish it this week due me feeling a bit ill the last few days. Hopefully I'll be able to finish up the review by Monday.
Comment #10
MegaChriz CreditAttribution: MegaChriz as a volunteer commentedCommitted #5 with a few minor changes (see interdiff).
Thanks Max!