To start implementing an UI for feeds tamper we have to implement permissions as in 7.x:
https://cgit.drupalcode.org/feeds_tamper/tree/feeds_tamper.module:

administer feeds_tamper
'tamper ' . $importer->id - Create, edit and delete plugins for %name feeds.

CommentFileSizeAuthor
#3 feeds_tamper-implement_permissions-2942067-3.patch1.46 KBmax-kuzomko
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

max-kuzomko created an issue. See original summary.

MegaChriz’s picture

MegaChriz CreditAttribution: MegaChriz as a volunteer commented
Status: Needs work » Active

Good idea. I set the status to "active", because the status "Needs work" is meant to be used when there is an existing patch on the issue that needs work. See https://www.drupal.org/node/156119.

max-kuzomko’s picture

max-kuzomko CreditAttribution: max-kuzomko at Smartweb for Fibonacci Web Studio commented
Status: Active » Needs review
FileSize
feeds_tamper-implement_permissions-2942067-3.patch1.46 KB

Thanks, @MegaChriz! I have attached the patch.

MegaChriz’s picture

MegaChriz CreditAttribution: MegaChriz as a volunteer commented
Status: Needs review » Fixed

I've checked the permissions page and gave the authenticated user one of the Tamper permission. Then in Devel's execute PHP code I evaluated the following code:

$account = user_load(12);
var_dump($account->hasPermission('tamper myfeed'));

Which resulted into bool(true).
For an other tamper permission (not checked for the authenticated user) this resulted into bool(false).

So looks good to me!

Committed #3. On commit I removed the D7 version of the code as well (probably all D7 code could just be removed).

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.