Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.This is a follow-up issue of https://www.drupal.org/project/yoast_seo/issues/2730333#comment-12457300
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 2940583.patch | 20.33 KB | chr.fritsch |
| |||
Comments
Comment #2
chr.fritschSince #2917280: [META] Node preview sandbox is committed, the Yoast Seo module got basically support for all content entities OOTB.
And I think that change made the config form obvious. And it also brings some flaws.
Users have learned from other modules, e.g. metatag, that adding a field brings new functionality. So when someone adds his own field_seo to taxonomy term the config form wouldn't represent that. That could lead to some confusion.
IMHO, the config form doesn't bring any value to the user. Everything it does could be easily done by the users themselves.
The main purpose of this module is the field widget and that's where we should concentrate on.
As I said before, the code would also be much cleaner.
Comment #3
KingdutchI've discussed internally to find out why this was not the case in the first place. It seems to be that this might've been aimed to accommodate less tech savvy users. However, I agree with you that it's better to educate them on the Drupal way.
This coupled with a bug in the FieldManager that causes #2938278: Allow editing of page title and meta description to not work for Taxonomies has me convinced that we should remove the custom configuration page in favour of using the Drupal Field UI.
I'd like to modify the patch you provided in #2730333: Content Analysis for Entities, not just nodes slightly to be able to use the SeoManager or FieldManager as a reporting service to easily find all the entities that have a Real-Time SEO field attached (encapsulating whatever logic is needed for that), with eye on some planned future functionality.
Additionally tests will need to be updated. I hope to have some time for this tomorrow afternoon.
Comment #4
chr.fritschI am glad to hear that you will follow my proposal.
Here is an updated patch.
Comment #6
KingdutchI have committed your patch with a few adjustments:
- I have removed the tests for the configuration form as well as they were no longer useful.
- I have reimplemented the getEnabledBundles function on the SeoManager so it can be used in reporting at a later point.
I have created the following follow-up issues to bring back tests:
#2941878: Write test for title and description editing
#2941877: Write test for SeoManager::getEnabledBundles
I consider those blockers for a stable release.