Split SettingsTrayBlockFormTest into multiple class to only enable modules when needed

Here is the patch

To be sure I didn't copy a function and forget to paste it 😱.... I ran grep -r 'public function test' . from inside core/modules/settings_tray/tests/src/FunctionalJavascript

For 8.6.x

./SettingsTrayBlockFormTest.php: public function testBlocks($theme, $block_plugin, $new_page_text, $element_selector, $label_selector, $button_text, $toolbar_item) {
./SettingsTrayBlockFormTest.php: public function testQuickEditLinks() {
./SettingsTrayBlockFormTest.php: public function testEditModeEnableDisable() {
./SettingsTrayBlockFormTest.php: public function testCustomBlockLinks() {
./SettingsTrayBlockFormTest.php: public function testValidationMessages() {
./SettingsTrayBlockFormTest.php: public function testOverriddenBlock() {
./SettingsTrayBlockFormTest.php: public function testOverriddenConfigurationRemoved() {

With patch

./OverriddenConfigurationTest.php: public function testOverriddenConfigurationRemoved() {
./OverriddenConfigurationTest.php: public function testOverriddenBlock() {
./QuickEditIntegrationTest.php: public function testQuickEditLinks() {
./QuickEditIntegrationTest.php: public function testCustomBlockLinks() {
./SettingsTrayBlockFormTest.php: public function testBlocks($theme, $block_plugin, $new_page_text, $element_selector, $label_selector, $button_text, $toolbar_item) {
./SettingsTrayBlockFormTest.php: public function testEditModeEnableDisable() {
./SettingsTrayBlockFormTest.php: public function testValidationMessages() {

So the same 7 test methods are still there 💫🎉

Duh! Forgot @group from new tests

Double duh!

Apparently you can't just put @group wherever you want

Re-roll after #2938309: Only install Quick Edit when necessary for Settings Tray tests

Basically #2938309 gets reverted because it was temp fix to get the test failure fixed.

Rerolled after #2905098: Change block entity form handler from 'off_canvas' to 'settings_tray'

I messed up the reroll in #8 because I didn't add the new files 😰

Ok @rajeshwari10 thanks for the patch.

Instead of review the patch though I found it easier to revert the commit that cause the patch not to able to be applied: https://cgit.drupalcode.org/drupal/commit/?id=a2ae6fd09c14bc0993a919b93a...

Apply the from #10 and then undo the above revert.

I also then split out testBlockConfigAccess() which is new since #10 into its own class. This allows not enabling a couple modules in SettingsTrayBlockFormTest

@borisson_ thanks for the review.

1. I don't thinking moving this into the base class makes sense because each subclass overwrites this property. They don't get merged with the parent so unless multiple subclasses are going to the same exact set of modules as the base class it doesn't make sense. Also core test classes are @internal be default so we only have to worry about core sub classes defined in this module.

2. fixed
3. I have moved the comment to the bottom of the list of modules and now settings_tray_test_css is the last module in all classes with the comment above. Now it should be clear it only applies to the 1 module. I would like to keep the comment on all test classes because there is no $modules property on the base class. So since all of the classes with this comment don't extend each other it would make sense they all should be able to be read without reading the other classes.
4-5. Fixed
6. Shorten up the comment.

re #21.1/#22.1 yes they do get merged in.

🧠💥
Good to know.

I have moved $modules to \Drupal\Tests\settings_tray\FunctionalJavascript\SettingsTrayTestBase::$modules
I was able remove a bunch of ones from the list that probably shouldn't have been there because they are actually dependencies of settings_tray

Thanks @alexpott for committing and the explanation. Much better now

Also thanks to @rajeshwari10 and @borisson_