*   Additional custom keys/values, that are not part of field storage
   *   definition, can be passed in definitions. The most common setting, passed
   *   along the ID definition, is 'alias' used by SqlBase source plugin:

This should say that the 'alias' is for a table alias prefix to apply to the field name. Currently it's not clear whether it's a table alias or an alias for the field.

CommentFileSizeAuthor
#4 MigrateSourceInterface--getIds--2939748-4.patch1.04 KBmsankhala
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joachim created an issue. See original summary.

joachim’s picture

joachim CreditAttribution: joachim at Torchbox commented
Title: MigrateSourceInterface::getIds() should document that the field name can specify the table » MigrateSourceInterface::getIds() doesn't allow field names to specify the table
Issue summary: View changes
joachim’s picture

joachim CreditAttribution: joachim at Torchbox commented
Title: MigrateSourceInterface::getIds() doesn't allow field names to specify the table » MigrateSourceInterface::getIds() doesn't clearly document what the 'alias' property does
Component: migration system » documentation
Issue summary: View changes
msankhala’s picture

msankhala CreditAttribution: msankhala as a volunteer and at Srijan | A Material+ Company commented
Status: Active » Needs review
FileSize
MigrateSourceInterface--getIds--2939748-4.patch1.04 KB

Here is a patch.

msankhala’s picture

msankhala CreditAttribution: msankhala as a volunteer and at Srijan | A Material+ Company commented
Issue tags: +Novice
surbz’s picture

surbz CreditAttribution: surbz at Srijan | A Material+ Company commented

Thanks @msankhala for this patch.
I can confirm that the patch applies cleanly and provides a clearer description now.

surbz’s picture

surbz CreditAttribution: surbz at Srijan | A Material+ Company commented
Status: Needs review » Reviewed & tested by the community

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce commented
Status: Reviewed & tested by the community » Fixed

Crediting @joachimfor finding and creating this issue.

Committed and pushed 3509098e6b to 8.7.x and d20bcc9eb0 to 8.6.x. Thanks!

  • alexpott committed 3509098 on 8.7.x 
    Issue #2939748 by msankhala, joachim: MigrateSourceInterface::getIds()...

  • alexpott committed d20bcc9 on 8.6.x 
    Issue #2939748 by msankhala, joachim: MigrateSourceInterface::getIds()...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.