Problem/Motivation

The constructor of \Drupal\facets\Widget\WidgetPluginBase incorrectly overrides \Drupal\Component\Plugin\PluginBase::__construct and sets the internal $pluginId and $pluginDefinition definitions to NULL.
This for example makes it impossible to use the plugin ID of a facet in a processor.

Proposed resolution

Add the missing parameters to the constructor and correctly override the plugin base constructor.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 2939728-5.patch4.13 KBborisson_
#5 interdiff-2939728.txt3.33 KBborisson_
#2 correct_widget_plugin_base_constructor-2939728-2.patch820 bytesErik Frèrejean
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Erik Frèrejean created an issue. See original summary.

Erik Frèrejean’s picture

Erik Frèrejean
Primary language Dutch
Location 🏴‍☠️
CreditAttribution: Erik Frèrejean at KennisMeester commented
Status: Active » Needs review
FileSize
correct_widget_plugin_base_constructor-2939728-2.patch820 bytes
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: correct_widget_plugin_base_constructor-2939728-2.patch, failed testing. View results

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented
Status: Needs work » Needs review
FileSize
interdiff-2939728.txt3.33 KB
2939728-5.patch4.13 KB

  • borisson_ committed 77379d1 on 8.x-1.x 
    Issue #2939728 by borisson_, Erik Frèrejean: `WidgetPluginBase`...
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.