These should use the standard Drupal VERSION constant so the version of each is properly displayed on the administration pages.

CommentFileSizeAuthor
#5 umami-versions-2939018-4.patch1021 bytessmaz
#3 umami-theme.png105.25 KBsmaz
#3 umami-content.png28.46 KBsmaz
#2 umami-versions-2939018-2.patch1017 bytesDavid_Rothstein
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

David_Rothstein created an issue. See original summary.

David_Rothstein’s picture

David_Rothstein CreditAttribution: David_Rothstein as a volunteer commented
Status: Active » Needs review
FileSize
umami-versions-2939018-2.patch1017 bytes
smaz’s picture

smaz
Primary language English
Location England, UK
CreditAttribution: smaz at Five Mile Media commented
Status: Needs review » Reviewed & tested by the community
FileSize
umami-content.png28.46 KB
umami-theme.png105.25 KB

Tested a fresh installation, all works ok, cheers!

Umami theme version
Umami content module version

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: umami-versions-2939018-2.patch, failed testing. View results

smaz’s picture

smaz
Primary language English
Location England, UK
CreditAttribution: smaz at Five Mile Media commented
Status: Needs work » Needs review
FileSize
umami-versions-2939018-4.patch1021 bytes

Re-rolled so applies cleanly:

$ patch -p1 < umami-versions-2939018-2.patch
patching file core/profiles/demo_umami/modules/demo_umami_content/demo_umami_content.info.yml
patching file core/profiles/demo_umami/themes/umami/umami.info.yml
Hunk #1 succeeded at 2 with fuzz 2.

patch -p1 < umami-versions-2939018-4.patch
patching file core/profiles/demo_umami/modules/demo_umami_content/demo_umami_content.info.yml
patching file core/profiles/demo_umami/themes/umami/umami.info.yml

smaz’s picture

smaz
Primary language English
Location England, UK
CreditAttribution: smaz at Five Mile Media commented
Status: Needs review » Reviewed & tested by the community

RTBC as my patch was just a re-roll.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Reviewed & tested by the community » Fixed

Great find, thanks!

  • Gábor Hojtsy committed 490ad56 on 8.6.x 
    Issue #2939018 by smaz, David_Rothstein: Umami theme and modules don't...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.