NOTE: This issue was originally about the design of the toolbar warning message, but wound up just being about the wording in the end (i.e. this issue summary is out of date). Discussion about the design has moved to #2945378: Finalize design for Toolbar warning message, and change the install screen design to match.
Problem/Motivation
This is a follow-up to "Set toolbar warning message to only appear on admin/edit pages" -#2938186: Set toolbar warning message to only appear on admin/edit pages
This issue is for what the design of the warning message is going to look like - colours/contrast/etc. Current state:
Proposed resolution
Define how to tone down
Remaining tasks
- Define the visual changes
- Define the desired text
- Define the link to point to
- Implement it (taking into account possible translations)
- Accessibility review
User interface changes
To define
Comment | File | Size | Author |
---|---|---|---|
#28 | 2938800-28.patch | 2.87 KB | markconroy |
#32 | 2938800 - Toolbar warning.png | 173.49 KB | navneet0693 |
#31 | Extend___Umami_Food_Magazine-warning-focus.png | 26.46 KB | Eli-T |
#31 | Content___Umami_Food_Magazine-warning.png | 24.04 KB | Eli-T |
#29 | local-patch.png | 57.01 KB | cehfisher |
Comments
Comment #2
David_Rothstein CreditAttribution: David_Rothstein as a volunteer commentedIs this supposed to be about the wording of the toolbar message too, or really only the visual design? (I couldn't find a separate issue about the toolbar wording, so I assume it's here.)
Here's a possible starter patch, which touches the wording only. See #2938189-9: [META] Finalise the wording of the messages in installer, toolbar and on the status report page for discussion and screenshots.
Comment #3
David_Rothstein CreditAttribution: David_Rothstein as a volunteer commentedRegarding the design, the issue summary of #2938186: Set toolbar warning message to only appear on admin/edit pages says:
I completely agree, and I would just like to point out that the most obvious way to make it less aggressive is to get rid of the yellow exclamation-point warning icon....
This message is not really a warning condition - rather, it is informational in nature. Designing it to look like an informational message would make it way less distracting, so I suggest considering that. Drupal even has an "i" information icon (or at least used to, in Drupal 7?) which could be used instead of the warning icon.
Comment #4
ckrinaThank you @David_Rothstein, indeed this is for the wording too.
As discussed in the last Out of the Box call, I'm uploading an screenshot of the Toolbar warning message with a link to take into account more possible solutions. The idea of the link is not trying to solve all we need to communicate in one phrase.
Another thing that we should take into account is the length of the messages because it can be really long in translations.
Also adding @andrewmacpherson accessibility suggestions here from the previous issue:
Adding another issue that @markconroy found in the meta issue:
In the OOTB channel it was suggested to have an Out of The Box Guide in the Documentation, so maybe it would be a good place to link.
Comment #5
ckrinaComment #6
ckrinaWe discussed this in the UX meeting and @benfisher suggested to use hook_help for the link instead of a Drupal.org issue. He mentioned that it would help us to have it updated too, compared with the suggestion of creating a Guide in documentation and linking it.
@roland.molnar suggested this code as an example:
Here's his screenshot testing it:
About the visual changes, it hasn't been an detailed list of changes to do, just the need to calm it down.
Comment #7
David_Rothstein CreditAttribution: David_Rothstein as a volunteer commentedI actually had a similar thought (see #2822414-61: Redesign the 'install profile selection' installer screen to allow for experimental profiles and more information, and that issue has some already-written text to use as a starting point). It is good to know that it actually works!
Presumably, if the Help module is disabled (or if the current user doesn't have access to it) then the toolbar message just wouldn't be shown at all?
Comment #8
ckrinaOh, good point! This behaviour needs to be defined then.
I wouldn't remove the warning message or even the option to have a link, but no idea if this is even possible to override it when the help is enabled...
Comment #9
markconroy CreditAttribution: markconroy as a volunteer and at Annertech commentedMy preference would be for it to link to an internal Umami page (presumably using the Basic Page content type). Then we'd know it's always going to be there, whether Help module is enabled or not.
Also, it would give another example content page. I think we've only got on Basic Page node at the moment!
Comment #10
ckrina@markconroy right, that would help us avoiding to check if help is activated or not. +1 to that. I guess it should be added in this issue?
Comment #11
markconroy CreditAttribution: markconroy as a volunteer and at Annertech commentedAs a design, I quite like what you have in #4 Ckrina - short sentence with the blue link.
Comment #12
David_Rothstein CreditAttribution: David_Rothstein as a volunteer commentedSomeone could still delete the Basic Page though. I actually think that's more likely than turning off the Help module.
Having it depend on the Help module sort of made sense to me because it's essentially help text... However, I guess another option could to be to have it go to an entirely custom page defined via Drupal's routing system (i.e. not a piece of Basic Page content, but something that isn't a node and which you can't delete). However, that would be a bit outside the way Drupal modules usually provide this kind of information.
Comment #13
markconroy CreditAttribution: markconroy as a volunteer and at Annertech commentedWould the safest be to just link to a documentation page on Drupal.org?
Comment #14
David_Rothstein CreditAttribution: David_Rothstein as a volunteer commentedI suppose it would.
But it would be a good idea for this profile to have some help text anyway (and the normal pattern is basically that the help text is what links off to drupal.org for more in-depth information).
I could see it going either way... but don't think it would be that big of a deal if this message just disappeared for people who turned off the Help module. If they don't want helpful messages, then they don't have to see them :)
Comment #15
ckrinaSo we are blocked on this decision: where should we link the warning message from the toolbar?", and options are:
My vote would go for default content page so we don't depend from external things, and on this internal page link to Documentation on Drupal.org when we have a guide. And for now we can just explain what we need to say in the internal page.
Any other opinion?
Comment #16
markconroy CreditAttribution: markconroy as a volunteer and at Annertech commentedI agree with @ckrina on this. I'd much prefer to have this as an internal page.
I propose we set the path to /experimental and then we can have this issue fixed, while we focus on the content.
Comment #17
markconroy CreditAttribution: markconroy as a volunteer and at Annertech commentedPatch attached to set path to /experimental
Comment #18
yoroy CreditAttribution: yoroy at Roy Scholten commentedYes lets go for an internal page, that's the best way forward for now. Can always link to a docs page from inside its content, eventually.
Comment #19
ckrinaIt would be great that someone tests it also, but for me it's working fine. I've just created a follow-up for the internal page: #2941582: Create a drupal.org documentation page for Umami profile to explain why it shouldn't be used in production sites.
Comment #21
larowlanI think this should be postponed on #2941582: Create a drupal.org documentation page for Umami profile to explain why it shouldn't be used in production sites, we can't link to a page that doesn't exist.
Or alternatively, incorporated over there, with review credits applied from here to there.
And then close this as duplicate
Comment #22
David_Rothstein CreditAttribution: David_Rothstein as a volunteer commentedThat issue was committed, so this can be un-postponed now.
However, it definitely shouldn't be closed as a duplicate, since fixing the link wasn't the only thing this issue was about. (Whether this issue still needs the "Umami beta blocker" tag, though, is another question - from my point of view the remaining work here is definitely a stable-release blocker, but maybe not a beta blocker.)
Here is a reroll of the patch from #2 to apply cleanly now that the other issue has been committed. Still leaving it as needs work, since the patch only addresses the wording, but not the design (although those could probably be split into two issues if necessary).
Comment #23
larowlanFair enough, agree on the beta blocking status however. Changing the tag
Comment #24
smazI've tested the latest patch, this is ok in terms of warning text:
We seem to have lost track on the design for this: Are we happy with the current design?
If so, I'd consider this RTBC - we've discussed the text on our weekly initiative call, and the patch is fine & applies ok.
If this needs design changes, can we have a clear guidance on this?
Comment #25
smazNeeds review as to if we're happy with where we're up to or not.
Comment #26
smazAlso, a screenshot from hover.
Comment #28
markconroy CreditAttribution: markconroy as a volunteer and at Annertech commentedHere's a new patch that should fix the failing tests (testing the wrong string of text).
Comment #29
cehfisher CreditAttribution: cehfisher at Hook 42 commentedLooks like SimplyTest.me is still not working with 8.6.x, but locally the patch applied cleanly.
Comment #30
markconroy CreditAttribution: markconroy as a volunteer and at Annertech commentedDuring our weekly call yesterday we discussed the scope of this issue and decided that the design was not changing, only the content.
With that in mind, I think this is ready for RTBC.
Comment #31
Eli-TInstalled 8.6.x with patch in #28.
Warning appears as follows:
Warning tested to be present on /admin/content, /node/1/edit?destination=/admin/content, /node/add, /node/add/recipe, /admin/people
Warning tested to be not present on /, /recipes/super-easy-vegetarian-pasta-bake, /articles.
Warning has the following appearance on focus and on hover
Therefore moving this to RTBC
(comment edited to fix the path to the second embedded image)
Comment #32
navneet0693 CreditAttribution: navneet0693 as a volunteer and at QED42 commentedThere it is ! Tested on re-installed profile with patch in #28.
EDIT: Oopss! didn't scrolled up / refreshed the page, it was already in RTBC.
Comment #33
quicksketchComment #36
Gábor HojtsyThanks all! Great seeing stable blockers resolved :)
Comment #37
David_Rothstein CreditAttribution: David_Rothstein as a volunteer commentedSplitting it up makes sense, but the reason I proposed that this be a stable release blocker (and presumably the reason @larowlan went ahead and added that tag?) definitely wasn't the minor wording tweak - it was to improve the design. But that is a bit larger scope, so it is good to split it up.
I went ahead and created #2945378: Finalize design for Toolbar warning message, and change the install screen design to match as a child issue now, and transferred the "Umami stable blocker" tag there.