Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem
Composite element and multiple elements should fully support client-side and server-side conditional logic.
Solution
Improve Composite element and multiple element #states API support.
Tasks
- Setup test forms form composite and multiple elements.
- webform.webform.test_form_states_server_multiple.yml
- webform.webform.test_form_states_server_composite.yml
- Audit conditional behavior and better document concepts.
- Don't visually require the more items input element.
- Fix single composite element
- Fix multiple single element
- Fix multiple composite without required sub-elements
- Fix multiple composite with required sub-elements
- Check custom composite elements
- Write tests
Notes
- We might need to track and cache an element's #states API.
Comment | File | Size | Author |
---|---|---|---|
#16 | 2938651-16.patch | 55 KB | jrockowitz |
| |||
#13 | 2938651-13.patch | 36.89 KB | jrockowitz |
| |||
#10 | 2938651-10.patch | 32.81 KB | jrockowitz |
| |||
#6 | 2938651-6.patch | 24.27 KB | jrockowitz |
#4 | 2938651-4.patch | 0 bytes | jrockowitz |
Comments
Comment #4
jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commentedThe attached patch is not ready for any review. I just need to make sure I am not breaking any tests while refactoring some code.
Comment #6
jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commentedComment #10
jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commentedThe attached patch is not ready for any review. It needs to test coverage.
Comment #13
jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commentedComment #14
jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commentedThis is done and ready for review. I will probably commit it tomorrow.
Comment #16
jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commentedComment #17
jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commentedComment #19
jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented