API page: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Entity%21...

The see also link to \Drupal\Core\Entity\Query\QueryInterface::notexists() is not working.

CommentFileSizeAuthor
#3 fix_notExists_function_case_in_see_annotation-2938623-3.patch1.27 KBkmbremner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joachim created an issue. See original summary.

Ivan Berezhnov’s picture

Ivan Berezhnov CreditAttribution: Ivan Berezhnov as a volunteer and at Drupal Ukraine Community for Levi9 commented
Issue tags: +CSKyiv18
kmbremner’s picture

kmbremner
he/him
Primary language English
Location Wetherby, UK
CreditAttribution: kmbremner as a volunteer commented
FileSize
fix_notExists_function_case_in_see_annotation-2938623-3.patch1.27 KB

I believe this is because the @see annotation is lowercase but the function name is camel case.

Patch attached.

PS Be gentle, I'm new to this ;-)

kmbremner’s picture

kmbremner
he/him
Primary language English
Location Wetherby, UK
CreditAttribution: kmbremner as a volunteer commented
Status: Active » Needs review
joachim’s picture

joachim CreditAttribution: joachim as a volunteer commented
Status: Needs review » Reviewed & tested by the community

> I believe this is because the @see annotation is lowercase but the function name is camel case.

I reckon that's probably it too.

Thanks for the patch!

  • xjm committed cc2c955 on 8.6.x 
    Issue #2938623 by kmbremner: broken link in docs for Condition::...

  • xjm committed a55b528 on 8.5.x 
    Issue #2938623 by kmbremner: broken link in docs for Condition::...
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Status: Reviewed & tested by the community » Fixed

I grepped and confirmed that these are the only two cases (pun...) of the incorrect case:

[ibnsina:maintainer | Sat 08:15:07] $ grep -r "notexists" *
core/lib/Drupal/Core/Entity/Query/ConditionAggregateInterface.php:   * @see \Drupal\Core\Entity\Query\QueryInterface::notexists()
core/lib/Drupal/Core/Entity/Query/ConditionInterface.php:   * @see \Drupal\Core\Entity\Query\QueryInterface::notexists()

Committed and pushed to 8.6.x, and cherry-picked to 8.5.x as a documentation improvement. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.