Problem/Motivation

In #2926540: Split revision-handling methods to a separate entity storage interface and #2929496: Add dedicated interfaces to group methods dealing with revision translation and clean up the related documentation we reorganized the revision-related methods in ContentEntityInterface and ContentEntityStorageInterface and moved them into dedicated interfaces. As of now, only two revision-related methods are left in ContentEntityInterface.

Proposed resolution

Move ContentEntityInterface::getLoadedRevisionId() and ContentEntityInterface::updateLoadedRevisionId() to RevisionableInterface.

Remaining tasks

  • Validate the proposed solution
  • Write a patch
  • Reviews

User interface changes

None

API changes

See above

Data model changes

None

CommentFileSizeAuthor
#2 entity-move_rev-2938315-2.patch1.95 KBplach
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

plach created an issue. See original summary.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach as a volunteer commented
Status: Active » Needs review
FileSize
entity-move_rev-2938315-2.patch1.95 KB
amateescu’s picture

amateescu CreditAttribution: amateescu for Pfizer, Inc. commented
Status: Needs review » Reviewed & tested by the community

Look good to me, in line with what we've being doing recently with all the revision related methods :)

  • catch committed 4838f6d on 8.6.x 
    Issue #2938315 by plach: Move revision-related methods from...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed 4838f6d and pushed to 8.6.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.