Coding standards: Use short array syntax

Thanks for contributing this cleanup!

A coding style cleanup patch (like this) potentially breaks many other patches in the queue. As there is no stable release of this module yet, there are more important changes/patches in the issue queue that should be performed first. For that reason, I'm marking this issue as postponed – which doesn't mean that it shouldn't be committed; it just means that we should not risk to break more substantial patches at this point in time. I hope you can understand :-)

Breaking other patches in the issue queue is no blocker for complying with coding standards. I set the issue back to "needs review".

@sun: Your enthusiasm for the openid_connect module is very much appreciated. We'd also love to see this module changing from beta to RC or a feature complete first version for Drupal 8. Yet, postponing issues or setting them to RTBC should be something the community (at least two or three active users of the module plus a maintainer) should decide together.

A side-note: Actually, we already applied this patch and added some further fixes regarding coding standards (as a consistent use of the string translation trait, dependency injection, fixes to some comments/inline documentation, as well as last lines within some configuration files) within a development version of the module waiting to be pushed to the drupal.org repository, once the maintainers allow co-maintainership.

If you have further code changes to contribute, then you should attach a patch here or in a separate issue. Project maintainers usually do not use their commit access to sidestep Drupal's regular issue/patch and peer review process.

Already created according issues in the issue queue. See https://www.drupal.org/project/openid_connect/issues/2960885

Yet, have to extract the related patches from the development version. I'll do so within the next few days, after our local tests are done.

This patch includes the above changes and also fixes a missing comma within an array in openid_connect_connect_current_user().