Fix 'Drupal.Formatting.MultipleStatementAlignment' coding standard

Good to go.

We have 2 new ones to fix because these files were not being scanned before:

FILE: /Volumes/devdisk/dev/drupal/core/scripts/drupal.sh
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 62 | ERROR | [x] Equals sign not aligned with surrounding
    |       |     assignments; expected 24 spaces but found 1 space
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /Volumes/devdisk/dev/drupal/core/scripts/password-hash.sh
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 20 | ERROR | [x] Equals sign not aligned correctly; expected 1 space
    |       |     but found 2 spaces
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Time: 2 mins, 49.31 secs; Memory: 90Mb

Also:

For the drupal.sh one i'd just move the assignment of $cmd above the comment.

#4 Fixed the assignment in core/scripts/password-hash.sh

#5 Moved the assignment of $cmd

This patch passes coding standards and after I ran composer phpcs there are no remaining errors, just like the testbot tells us.

I'm unsure about adding this fix though.

1. +++ b/core/includes/theme.inc
   @@ -1355,9 +1355,9 @@ function template_preprocess_page(&$variables) {
   +  $variables['base_path']  = base_path();
   +  $variables['front_page'] = \Drupal::url('<front>');
   +  $variables['language']   = $language_interface;
   

   I'm not sure if this fix is correct. There isn't explicit documentation about this in https://www.drupal.org/docs/develop/standards/coding-standards#operators

   That was #2816445: Forbid using more than one space around operators, but it looks like that issue hasn't passed yet.

   So it looks like this is ok.

2. +++ b/core/modules/rest/tests/src/Functional/EntityResource/EntityResourceTestBase.php
   @@ -755,10 +755,10 @@ public function testPost() {
   -    $unparseable_request_body = '!{>}<';
   -    $parseable_valid_request_body   = $this->serializer->encode($this->getNormalizedPostEntity(), static::$format);
   -    $parseable_valid_request_body_2 = $this->serializer->encode($this->getSecondNormalizedPostEntity(), static::$format);
   -    $parseable_invalid_request_body = $this->serializer->encode($this->makeNormalizationInvalid($this->getNormalizedPostEntity(), 'label'), static::$format);
   +    $unparseable_request_body         = '!{>}<';
   +    $parseable_valid_request_body     = $this->serializer->encode($this->getNormalizedPostEntity(), static::$format);
   +    $parseable_valid_request_body_2   = $this->serializer->encode($this->getSecondNormalizedPostEntity(), static::$format);
   +    $parseable_invalid_request_body   = $this->serializer->encode($this->makeNormalizationInvalid($this->getNormalizedPostEntity(), 'label'), static::$format);
   
   @@ -985,9 +985,9 @@ public function testPatch() {
   -    $unparseable_request_body = '!{>}<';
   -    $parseable_valid_request_body   = $this->serializer->encode($this->getNormalizedPatchEntity(), static::$format);
   -    $parseable_valid_request_body_2 = $this->serializer->encode($this->getNormalizedPatchEntity(), static::$format);
   +    $unparseable_request_body         = '!{>}<';
   +    $parseable_valid_request_body     = $this->serializer->encode($this->getNormalizedPatchEntity(), static::$format);
   +    $parseable_valid_request_body_2   = $this->serializer->encode($this->getNormalizedPatchEntity(), static::$format);
   

   This moves us further away from #2816445: Forbid using more than one space around operators

#7.1 / #7.2 As far as I am concerned we are just bringing the current code base in line with our coding standards using automated testing tools. Once there is a change in the coding standard (like #2816445: Forbid using more than one space around operators), we will update the rule and then we have the tool available to fix violations automatically.

As I see it, having more spaces before the assignment is less common, although allowed. So, if we have to modify those lines, I would also go for only one space before the assignment.

I agree with #9, that sounds like the best way to fix this.

Ohh I see what you are getting at, we just remove the 'extra' spaces. Something like this?

Setting status back to 'Needs review' after #2973992: Permission issue in Nightwatch step marks all full testruns as unstable

Looks good now.

Here is the updated patch for 8.7.x.

Since it's just a reroll and passes all the tests, I'm setting this to RTBC.

Committed and pushed 6c40e077ef to 8.7.x and da3e9773c1 to 8.6.x. Thanks!

As a coding-standards fix this is eligible for commit during 8.6.x beta.

We include a brief list of coding standards changes in the release notes, since they affect core, contrib, and custom projects that use our standards.