Problem/Motivation

While looking at the language_content_settings migrations in response to #2936636: General migration issues from D6 ubercart with multiple languages I noticed that there was a dependency added that could be removed and the test was not robust enough.

Marking a bug report since the tests are not doing what is should.

Proposed resolution

Remove the dependency set in the alter.
It would be better if there were 2 tests, one executing d6_language_content_settings, and the other executing, d6_language_content_settings and d6_ubercart_language_content_settings. Since both are modified in an alter, it makes sense to test that the core migration doesn't modify the products and that the combination of both, does what it should in a complete migration.

Update the test to correctly test for translatability as per the test in core.

Remaining tasks

Write a patch
review
commit
Smile

CommentFileSizeAuthor
#2 2936658-2.patch10.66 KBquietone
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

quietone created an issue. See original summary.

quietone’s picture

FileSize
10.66 KB
quietone’s picture

Status: Active » Needs review

NR for testing

heddn’s picture

Is this ready for a final review?

quietone’s picture

Yes, it is.

heddn’s picture

Status: Needs review » Reviewed & tested by the community

Looking good here.

  • heddn committed afb5765 on 8.x-2.x authored by quietone
    Issue #2936658 by quietone, heddn: Remove dependency in...
heddn’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.