Problem/Motivation
While looking at the language_content_settings migrations in response to #2936636: General migration issues from D6 ubercart with multiple languages I noticed that there was a dependency added that could be removed and the test was not robust enough.
Marking a bug report since the tests are not doing what is should.
Proposed resolution
Remove the dependency set in the alter.
It would be better if there were 2 tests, one executing d6_language_content_settings, and the other executing, d6_language_content_settings and d6_ubercart_language_content_settings. Since both are modified in an alter, it makes sense to test that the core migration doesn't modify the products and that the combination of both, does what it should in a complete migration.
Update the test to correctly test for translatability as per the test in core.
Remaining tasks
Write a patch
review
commit
Smile
Comment | File | Size | Author |
---|---|---|---|
#2 | 2936658-2.patch | 10.66 KB | quietone |
Comments
Comment #2
quietone CreditAttribution: quietone at Acro Commerce commentedComment #3
quietone CreditAttribution: quietone at Acro Commerce commentedNR for testing
Comment #4
heddnIs this ready for a final review?
Comment #5
quietone CreditAttribution: quietone at Acro Commerce commentedYes, it is.
Comment #6
heddnLooking good here.
Comment #8
heddn