"Path alias" in PathFilterForm.php is not translated

File path : core\modules\path\src\Form\PathFilterForm.php at line no 33

Proposed resolution:
1) Locate the untranslated strings.
2) Wrap the strings in t() to allow translation.

CommentFileSizeAuthor
#3 translation-add-2936641-1.patch588 bytesalokvermaei
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alokvermaei created an issue. See original summary.

alokvermaei’s picture

alokvermaei CreditAttribution: alokvermaei commented
Title: Translate (t) tag missing on path filter form » "Path alias" in PathFilterForm.php is not translated
alokvermaei’s picture

alokvermaei CreditAttribution: alokvermaei commented
Assigned: alokvermaei » Unassigned
Status: Active » Needs review
FileSize
translation-add-2936641-1.patch588 bytes

here is the patch.

alokvermaei’s picture

alokvermaei CreditAttribution: alokvermaei commented
Assigned: Unassigned » alokvermaei
alokvermaei’s picture

alokvermaei CreditAttribution: alokvermaei commented
Assigned: alokvermaei » Unassigned

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

alokvermaei’s picture

alokvermaei CreditAttribution: alokvermaei commented
Issue tags: -path, -translation +Novice
navneet0693’s picture

navneet0693 CreditAttribution: navneet0693 as a volunteer and at QED42 commented
Status: Needs review » Reviewed & tested by the community
mohit1604’s picture

mohit1604 CreditAttribution: mohit1604 at Google Summer of Code commented

added test for 8.6.x , hope it shows green !

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 8.6.x-dev » 8.5.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.6.x and cherry-picked to 8.5.x. Thanks!

  • catch committed c338395 on 8.6.x 
    Issue #2936641 by alokvermaei: 'Path alias' in PathFilterForm.php is not...

  • catch committed 4ef2079 on 8.5.x 
    Issue #2936641 by alokvermaei: 'Path alias' in PathFilterForm.php is not...
alokvermaei’s picture

alokvermaei CreditAttribution: alokvermaei commented
alokvermaei’s picture

alokvermaei CreditAttribution: alokvermaei at Publicis Sapient commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.