Can we add vw and vh units to allowed values in the stylelinters?

We are using vw in the Out of the Box initiative and would be nice to not fail the linters.

CommentFileSizeAuthor
#2 add-vh-and-vw-to-stylelint-2935725-2.patch529 bytesmarkconroy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

markconroy created an issue. See original summary.

markconroy’s picture

markconroy CreditAttribution: markconroy as a volunteer and at Annertech commented
FileSize
add-vh-and-vw-to-stylelint-2935725-2.patch529 bytes
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii as a volunteer commented
Status: Active » Reviewed & tested by the community

This is required for committing the umami theme. Using these units is pretty common and these days the browser support for these is fine (https://caniuse.com/#feat=viewport-units).

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Reviewed & tested by the community » Fixed

Committed as 3d67ae3 and pushed to 8.6.x

Cherry-picked as 6c92a2a and pushed to 8.5.x.

  • larowlan committed 3d67ae3 on 8.6.x 
    Issue #2935725 by markconroy: Add vw and vh to the CSS stylelint

  • larowlan committed 6c92a2a on 8.5.x 
    Issue #2935725 by markconroy: Add vw and vh to the CSS stylelint

(...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.