Improve the coding standards compliance of the D7 module.

CommentFileSizeAuthor
#5 backup_migrate-n2935403-5.patch376.23 KBDamienMcKenna
#5 backup_migrate-n2935403-5.interdiff.txt136.6 KBDamienMcKenna
#4 interdiff-2935403-2-4.txt120.98 KBjacob.embree
#4 backup_migrate-coding-standards-2935403.patch289.19 KBjacob.embree
#2 backup_migrate-n2935403-2.patch212.34 KBDamienMcKenna
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna created an issue. See original summary.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Active » Needs review
FileSize
backup_migrate-n2935403-2.patch212.34 KB

WIP, this is just a basic run of phpcbf on the codebase.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Parent issue: » #2942331: Plan for Backup and Migrate 7.x-3.6
jacob.embree’s picture

jacob.embree CreditAttribution: jacob.embree at St. Louis Integration commented
FileSize
backup_migrate-coding-standards-2935403.patch289.19 KB
interdiff-2935403-2-4.txt120.98 KB

Here is a reroll with some additions, but nowhere close to everything.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
FileSize
backup_migrate-n2935403-5.interdiff.txt136.6 KB
backup_migrate-n2935403-5.patch376.23 KB

Improvements.

Status: Needs review » Needs work

The last submitted patch, 5: backup_migrate-n2935403-5.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

  • DamienMcKenna committed 805630a on 7.x-3.x 
    Issue #2935403 by DamienMcKenna, jacob.embree: Improve coding standards...
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs work » Fixed

This is good for now. Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.