Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
As per #2935144: DisallowLongArraySyntaxSniff is broken because DrupalPractice_Project::getCoreVersion() makes incorrect assumptions coder is not checking for long array syntax.
Proposed resolution
Move to the generic sniff as it works perfectly.
To test add $a = array();
to core/lib/Drupal/Core/Access/AccessArgumentsResolverFactory.php
and then do ../vendor/bin/phpcs --standard=phpcs.xml.dist --runtime-set installed_paths COMPLETE_PATH/vendor/drupal/coder/coder_sniffer/ -ps lib/Drupal/Core/Access/AccessArgumentsResolverFactory.php
Remaining tasks
User interface changes
None
API changes
None
Data model changes
None
Comment | File | Size | Author |
---|---|---|---|
#2 | 2935151-2.patch | 3.86 KB | alexpott |
Comments
Comment #2
alexpotta patch
Comment #3
dawehnerNice find and fix!
Comment #4
larowlannice!
Committed as 3af9d07 and pushed to 8.5.x.