Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
hook_rest_type_uri_alter()
and hook_rest_relation_uri_alter()
were deprecated in #2758897: Move rest module's "link manager" services to serialization module
That was before we had the ability to @trigger_error()
for deprecated hooks: https://www.drupal.org/node/2881531
Proposed resolution
Use ModuleHandlerInterface::invokeDeprecated()
and alterDeprecated()
to invoke these hooks.
Modify any tests to include @expectedDeprecation
if they use implementations of these hooks.
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#7 | 2934994-7.patch | 4.08 KB | Wim Leers |
Comments
Comment #2
Wim LeersYES!
I'd tag this as novice, but I first want to get some experience with this myself.
Comment #5
Wim LeersComment #6
Mile23I think the triggered message and the @deprecated docblock message should be the same. Telling someone what to implement instead is much more useful, so we should change the @deprecated message to reflect that.
Comment #7
Wim LeersDone.
Comment #8
borisson_It doesn't look like anything else should be fixed in this issue. But I'm not sure, so not setting to RTBC. If Wim can confirm that nothing else should be fixed here, this is RTBC for me.
Comment #9
Wim LeersI confirm!
Comment #10
borisson_Awesome, sorry for not setting it to RTBC earlier, it looked so simple that I wasn't sure. Thank you!
Comment #11
Wim Leersnp at all :)
Thank you for the review/RTBC!
Comment #12
catchCommitted 5b43b3d and pushed to 8.6.x. Thanks!
Comment #13
catch