Problem/Motivation

Drupal calls should be avoided in classes that are able to use dependency injection

Proposed resolution

Adapt class (service) to inject dependency

Remaining tasks

Review patch

User interface changes

None

API changes

None

Data model changes

None

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

GeduR created an issue. See original summary.

GeduR’s picture

Status: Active » Needs review
FileSize
2.64 KB

Also, small changes have been done to follow coding standards (phpcs).

Please review!

nkoporec’s picture

Status: Needs review » Reviewed & tested by the community

Hey @GeduR.I have tested your last patch and it's working as expected.

  • boshtian committed e335619 on 8.x-1.x authored by GeduR
    Issue #2933088 by GeduR, nkoporec: Use dependency injection in...
boshtian’s picture

Status: Reviewed & tested by the community » Fixed

  • boshtian committed e335619 on 8.x-4.x authored by GeduR
    Issue #2933088 by GeduR, nkoporec: Use dependency injection in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.