Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
Drupal calls should be avoided in classes that are able to use dependency injection
Proposed resolution
Adapt class (service) to inject dependency
Remaining tasks
Review patch
User interface changes
None
API changes
None
Data model changes
None
Comment | File | Size | Author |
---|---|---|---|
#2 | context-theme_switcher_negotiator-dependency_injection-2933088-2.patch | 2.64 KB | GeduR |
Comments
Comment #2
GeduR CreditAttribution: GeduR at Metadrop commentedAlso, small changes have been done to follow coding standards (phpcs).
Please review!
Comment #3
nkoporecHey @GeduR.I have tested your last patch and it's working as expected.
Comment #5
boshtian CreditAttribution: boshtian at Agiledrop - Your Trusted Drupal Teammates commented