menu_block.schema.yml defines "expanded".
MenuBlock::defaultConfiguration() defines "expand".

Looks like it got changed at some point, but the default config wasn't updated...

CommentFileSizeAuthor
#16 interdiff_2932048-14-16.txt420 bytesrajeevk
#16 2932048-16.patch881 bytesrajeevk
#14 2932048-14.patch461 bytesPrashant.c
#12 2932048-12.patch420 bytesharsha012
#4 patch-clean.png29.87 KBMaheshwaran.j
#2 menu_block-config_mismatch-2932048-1.patch470 bytespingers
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pingers created an issue. See original summary.

pingers’s picture

pingers CreditAttribution: pingers as a volunteer and at University of Adelaide commented
Status: Active » Needs review
FileSize
menu_block-config_mismatch-2932048-1.patch470 bytes

Here's a patch.

Maheshwaran.j’s picture

Maheshwaran.j CreditAttribution: Maheshwaran.j as a volunteer and at DrupalPartners for Innoppl Technologies Pvt. Ltd commented
Assigned: Unassigned » Maheshwaran.j
Maheshwaran.j’s picture

Maheshwaran.j CreditAttribution: Maheshwaran.j as a volunteer and at DrupalPartners for Innoppl Technologies Pvt. Ltd commented
FileSize
patch-clean.png29.87 KB

Hi Pingers

Your Patch applies cleanly for version 8.x-1.x. Please refer the screenshot.I have no idea why your patch did not go through automated testing.

Maheshwaran.j’s picture

Maheshwaran.j CreditAttribution: Maheshwaran.j as a volunteer and at DrupalPartners for Innoppl Technologies Pvt. Ltd commented
Assigned: Maheshwaran.j » Unassigned
pingers’s picture

pingers CreditAttribution: pingers as a volunteer and at University of Adelaide commented

There's a simpler answer than you might think... there are no 8.x-1.x tests.

Maheshwaran.j’s picture

Maheshwaran.j CreditAttribution: Maheshwaran.j as a volunteer and at DrupalPartners for Innoppl Technologies Pvt. Ltd commented

Pingers

So only Core modules go through automated testing? Every dev versions of a module do not go through the testing.?

pingers’s picture

pingers CreditAttribution: pingers as a volunteer and at University of Adelaide commented

Contrib modules go through testing... if there are tests for the module :)

See http://cgit.drupalcode.org/menu_block/tree/src - there are no tests to run.

Maheshwaran.j’s picture

Maheshwaran.j CreditAttribution: Maheshwaran.j as a volunteer and at DrupalPartners for Innoppl Technologies Pvt. Ltd commented

Thanks .! :) Now I understand how it works.

Maheshwaran.j’s picture

Maheshwaran.j CreditAttribution: Maheshwaran.j as a volunteer and at DrupalPartners for Innoppl Technologies Pvt. Ltd commented
Status: Needs review » Reviewed & tested by the community
joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet at The University of British Columbia commented
Status: Reviewed & tested by the community » Needs work

It looks like we should change the schema from 'expanded' to 'expand' because we are using 'expand' everywhere else.

harsha012’s picture

harsha012 CreditAttribution: harsha012 as a volunteer and commented
Status: Needs work » Needs review
FileSize
2932048-12.patch420 bytes

fixed as per #11

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet at The University of British Columbia commented
Status: Needs review » Needs work

thanks @harsha012 here's the docs on how to make a schema change:
https://www.drupal.org/docs/8/api/update-api/updating-configuration-in-d...

We need to get an update hook for existing sites.

Feel free to disagree with me on the name change, I can't think which is best, just seemed like less work to go to 'expand'

Prashant.c’s picture

Prashant.c
he/him
Primary language English
Location Dharamshala
CreditAttribution: Prashant.c as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented
Status: Needs work » Needs review
FileSize
2932048-14.patch461 bytes

@joelpittet

I have just started learning the Config system so tried my hands for updating the Config Object name PFA.

Please let me know if this is the correct way and will it work ?.

rajeevk’s picture

rajeevk
Location London
CreditAttribution: rajeevk as a volunteer and at Sirius commented
Status: Needs review » Needs work

Latest patch (#15) missing change in configuration schema YML file. Changing to need work..

rajeevk’s picture

rajeevk
Location London
CreditAttribution: rajeevk as a volunteer and at Sirius commented
Status: Needs work » Needs review
FileSize
2932048-16.patch881 bytes
interdiff_2932048-14-16.txt420 bytes
joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet at The University of British Columbia commented

This looks great, if someone can give it a quick review and test, I'll commit.

Dinesh18’s picture

Dinesh18 CreditAttribution: Dinesh18 as a volunteer commented
Status: Needs review » Reviewed & tested by the community

I have tested the patch manually and it looks good to me.
+1 to RTBC

  • joelpittet committed 5edaded on 8.x-1.x authored by RajeevK 
    Issue #2932048 by RajeevK, pingers, harsha012, Prashant.c, Maheshwaran.j...
joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet at The University of British Columbia commented
Status: Reviewed & tested by the community » Fixed

Thank you I've pushed this to the latest dev branch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews as a volunteer commented
Parent issue: » #3066521: Plan for Menu block 8.x-1.6 release