\Drupal\facets\QueryType\QueryTypePluginBase::$results is documented as an array of result objects, but it's actually an array of arrays,

it's documentation should be array[], it's an array of count and filter and should be documented like that.

CommentFileSizeAuthor
#4 facets-documentation-2931481-4-D8.patch456 bytesioana apetri
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

borisson_ created an issue. See original summary.

borisson_ credited claudiu.cristea.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and commented

Crediting claudiu for finding and reporting this issue in slack, and figuring out what is should be.

ioana apetri’s picture

ioana apetri CreditAttribution: ioana apetri at OPTASY commented
Status: Active » Needs review
FileSize
facets-documentation-2931481-4-D8.patch456 bytes

Here's the patch with @var documentation changed.
Please review. Thanks:)

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and commented
Status: Needs review » Fixed

Committed and pushed, thanks!

  • borisson_ committed 7afa25d on 8.x-1.x authored by yo30 
    Issue #2931481 by yo30, claudiu.cristea: \Drupal\facets\QueryType\...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.